* [PATCH][trace-cmd] trace-record: wrong refferencing
@ 2010-02-25 17:40 Jiri Olsa
2010-02-25 17:56 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Olsa @ 2010-02-25 17:40 UTC (permalink / raw)
To: rostedt; +Cc: linux-kernel, Jiri Olsa
hi,
looks like bug this time :)
wbr,
jirka
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
diff --git a/trace-record.c b/trace-record.c
index cdfc857..2a754b9 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -116,7 +116,7 @@ struct tracecmd_recorder *tracecmd_create_recorder(const char *file, int cpu)
int fd;
fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
- if (recorder->fd < 0)
+ if (fd < 0)
return NULL;
recorder = tracecmd_create_recorder_fd(fd, cpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][trace-cmd] trace-record: wrong refferencing
2010-02-25 17:40 [PATCH][trace-cmd] trace-record: wrong refferencing Jiri Olsa
@ 2010-02-25 17:56 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2010-02-25 17:56 UTC (permalink / raw)
To: Jiri Olsa; +Cc: linux-kernel
On Thu, 2010-02-25 at 18:40 +0100, Jiri Olsa wrote:
> hi,
>
> looks like bug this time :)
Indeed it is.
Applied, thanks!
-- Steve
>
> wbr,
> jirka
>
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> diff --git a/trace-record.c b/trace-record.c
> index cdfc857..2a754b9 100644
> --- a/trace-record.c
> +++ b/trace-record.c
> @@ -116,7 +116,7 @@ struct tracecmd_recorder *tracecmd_create_recorder(const char *file, int cpu)
> int fd;
>
> fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
> - if (recorder->fd < 0)
> + if (fd < 0)
> return NULL;
>
> recorder = tracecmd_create_recorder_fd(fd, cpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-25 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-25 17:40 [PATCH][trace-cmd] trace-record: wrong refferencing Jiri Olsa
2010-02-25 17:56 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®