From: Matthew Garrett <mjg@redhat.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: [PATCH 11/14] classmate-laptop: use a single MODULE_DEVICE_TABLE to get correct aliases
Date: Fri, 26 Feb 2010 10:18:44 -0500 [thread overview]
Message-ID: <1267197527-18062-12-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1267197527-18062-1-git-send-email-mjg@redhat.com>
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Instead of a MODULE_DEVICE_TABLE for every acpi_driver ids table, we
create a table containing all ids to export to get a module alias for
each one.
This will fix automatic loading of the driver when one of the ACPI
devices is not present (like the accelerometer, which is not present in
some models).
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/platform/x86/classmate-laptop.c | 31 +++++++++++++++++++++----------
1 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index ed90082..8cb20e4 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -34,6 +34,11 @@ struct cmpc_accel {
#define CMPC_ACCEL_SENSITIVITY_DEFAULT 5
+#define CMPC_ACCEL_HID "ACCE0000"
+#define CMPC_TABLET_HID "TBLT0000"
+#define CMPC_BL_HID "IPML200"
+#define CMPC_KEYS_HID "FnBT0000"
+
/*
* Generic input device code.
*/
@@ -282,10 +287,9 @@ static int cmpc_accel_remove(struct acpi_device *acpi, int type)
}
static const struct acpi_device_id cmpc_accel_device_ids[] = {
- {"ACCE0000", 0},
+ {CMPC_ACCEL_HID, 0},
{"", 0}
};
-MODULE_DEVICE_TABLE(acpi, cmpc_accel_device_ids);
static struct acpi_driver cmpc_accel_acpi_driver = {
.owner = THIS_MODULE,
@@ -366,10 +370,9 @@ static int cmpc_tablet_resume(struct acpi_device *acpi)
}
static const struct acpi_device_id cmpc_tablet_device_ids[] = {
- {"TBLT0000", 0},
+ {CMPC_TABLET_HID, 0},
{"", 0}
};
-MODULE_DEVICE_TABLE(acpi, cmpc_tablet_device_ids);
static struct acpi_driver cmpc_tablet_acpi_driver = {
.owner = THIS_MODULE,
@@ -477,17 +480,16 @@ static int cmpc_bl_remove(struct acpi_device *acpi, int type)
return 0;
}
-static const struct acpi_device_id cmpc_device_ids[] = {
- {"IPML200", 0},
+static const struct acpi_device_id cmpc_bl_device_ids[] = {
+ {CMPC_BL_HID, 0},
{"", 0}
};
-MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
static struct acpi_driver cmpc_bl_acpi_driver = {
.owner = THIS_MODULE,
.name = "cmpc",
.class = "cmpc",
- .ids = cmpc_device_ids,
+ .ids = cmpc_bl_device_ids,
.ops = {
.add = cmpc_bl_add,
.remove = cmpc_bl_remove
@@ -540,10 +542,9 @@ static int cmpc_keys_remove(struct acpi_device *acpi, int type)
}
static const struct acpi_device_id cmpc_keys_device_ids[] = {
- {"FnBT0000", 0},
+ {CMPC_KEYS_HID, 0},
{"", 0}
};
-MODULE_DEVICE_TABLE(acpi, cmpc_keys_device_ids);
static struct acpi_driver cmpc_keys_acpi_driver = {
.owner = THIS_MODULE,
@@ -607,3 +608,13 @@ static void cmpc_exit(void)
module_init(cmpc_init);
module_exit(cmpc_exit);
+
+static const struct acpi_device_id cmpc_device_ids[] = {
+ {CMPC_ACCEL_HID, 0},
+ {CMPC_TABLET_HID, 0},
+ {CMPC_BL_HID, 0},
+ {CMPC_KEYS_HID, 0},
+ {"", 0}
+};
+
+MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
--
1.6.6.1
next prev parent reply other threads:[~2010-02-26 15:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 15:18 [GIT PULL] x86 platform drivers tree Matthew Garrett
2010-02-26 15:18 ` [PATCH 01/14] MAINTAINERS: update drivers/platform/x86 information Matthew Garrett
2010-02-26 16:18 ` Thadeu Lima de Souza Cascardo
2010-02-26 16:39 ` Anisse Astier
2010-02-26 16:44 ` Anisse Astier
2010-02-26 23:58 ` Henrique de Moraes Holschuh
2010-02-26 21:53 ` Corentin Chary
2010-03-01 17:59 ` Len Brown
2010-03-01 18:02 ` Matthew Garrett
2010-03-01 18:23 ` Len Brown
2010-02-26 23:51 ` Peter Feuerer
2010-02-27 3:42 ` Jonathan Woithe
2010-02-27 4:39 ` Harald Welte
2010-02-26 15:18 ` [PATCH 02/14] compal-laptop: Add support for known Compal made Dell laptops Matthew Garrett
2010-02-26 15:18 ` [PATCH 03/14] compal-laptop: Replace sysfs support with rfkill support Matthew Garrett
2010-02-26 15:18 ` [PATCH 04/14] dell-laptop: Update rfkill state on kill switch Matthew Garrett
2010-02-27 8:06 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 05/14] dell-laptop: Fix platform device unregistration Matthew Garrett
2010-02-27 8:09 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 06/14] dell-laptop: Fix small memory leak Matthew Garrett
2010-02-26 15:18 ` [PATCH 07/14] dell-laptop: Block software state changes when rfkill hard blocked Matthew Garrett
2010-02-26 15:18 ` [PATCH 08/14] dell-laptop: Blacklist machines not supporting dell-laptop Matthew Garrett
2010-02-26 15:18 ` [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical address Matthew Garrett
2010-02-27 8:11 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 10/14] dell-laptop: Pay attention to which devices the hardware switch controls Matthew Garrett
2010-02-26 15:18 ` Matthew Garrett [this message]
2010-02-26 15:18 ` [PATCH 12/14] dell-laptop: Add another Dell laptop to the DMI whitelist Matthew Garrett
2010-02-26 15:18 ` [PATCH 13/14] hp-wmi: Add support for tablet rotation key Matthew Garrett
2010-02-27 8:12 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 14/14] toshiba_acpi: Add full hotkey support Matthew Garrett
2010-02-27 0:07 ` [GIT PULL] x86 platform drivers tree Henrique de Moraes Holschuh
2010-03-01 14:45 ` Matthew Garrett
2010-02-28 19:59 ` tip: origin tree build failure Ingo Molnar
2010-03-02 13:56 ` [PATCH] compal-laptop: Make it depend on CONFIG_RFKILL Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267197527-18062-12-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=cascardo@holoscopio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®