From: Matthew Garrett <mjg@redhat.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 04/14] dell-laptop: Update rfkill state on kill switch
Date: Fri, 26 Feb 2010 10:18:37 -0500 [thread overview]
Message-ID: <1267197527-18062-5-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1267197527-18062-1-git-send-email-mjg@redhat.com>
The rfkill interface on Dells only sends a notification that the switch
has been changed via the keyboard controller. Add a filter so we can
pick these notifications up and update the rfkill state appropriately.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
drivers/platform/x86/Kconfig | 1 +
drivers/platform/x86/dell-laptop.c | 48 ++++++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index f526e73..6848f21 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -79,6 +79,7 @@ config DELL_LAPTOP
depends on BACKLIGHT_CLASS_DEVICE
depends on RFKILL || RFKILL = n
depends on POWER_SUPPLY
+ depends on SERIO_I8042
default n
---help---
This driver adds support for rfkill and backlight control to Dell
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 3780994..9d7e0be 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -22,6 +22,7 @@
#include <linux/rfkill.h>
#include <linux/power_supply.h>
#include <linux/acpi.h>
+#include <linux/i8042.h>
#include "../../firmware/dcdbas.h"
#define BRIGHTNESS_TOKEN 0x7d
@@ -214,6 +215,18 @@ static const struct rfkill_ops dell_rfkill_ops = {
.query = dell_rfkill_query,
};
+static void dell_update_rfkill(struct work_struct *ignored)
+{
+ if (wifi_rfkill)
+ dell_rfkill_query(wifi_rfkill, (void *)1);
+ if (bluetooth_rfkill)
+ dell_rfkill_query(bluetooth_rfkill, (void *)2);
+ if (wwan_rfkill)
+ dell_rfkill_query(wwan_rfkill, (void *)3);
+}
+static DECLARE_DELAYED_WORK(dell_rfkill_work, dell_update_rfkill);
+
+
static int __init dell_setup_rfkill(void)
{
struct calling_interface_buffer buffer;
@@ -338,6 +351,30 @@ static struct backlight_ops dell_ops = {
.update_status = dell_send_intensity,
};
+bool dell_laptop_i8042_filter(unsigned char data, unsigned char str,
+ struct serio *port)
+{
+ static bool extended;
+
+ if (str & 0x20)
+ return false;
+
+ if (unlikely(data == 0xe0)) {
+ extended = true;
+ return false;
+ } else if (unlikely(extended)) {
+ switch (data) {
+ case 0x8:
+ schedule_delayed_work(&dell_rfkill_work,
+ round_jiffies_relative(HZ));
+ break;
+ }
+ extended = false;
+ }
+
+ return false;
+}
+
static int __init dell_init(void)
{
struct calling_interface_buffer buffer;
@@ -373,6 +410,13 @@ static int __init dell_init(void)
goto fail_rfkill;
}
+ ret = i8042_install_filter(dell_laptop_i8042_filter);
+ if (ret) {
+ printk(KERN_WARNING
+ "dell-laptop: Unable to install key filter\n");
+ goto fail_filter;
+ }
+
#ifdef CONFIG_ACPI
/* In the event of an ACPI backlight being available, don't
* register the platform controller.
@@ -410,6 +454,8 @@ static int __init dell_init(void)
return 0;
fail_backlight:
+ i8042_remove_filter(dell_laptop_i8042_filter);
+fail_filter:
dell_cleanup_rfkill();
fail_rfkill:
platform_device_del(platform_device);
@@ -424,6 +470,8 @@ fail_platform_driver:
static void __exit dell_exit(void)
{
+ cancel_delayed_work_sync(&dell_rfkill_work);
+ i8042_remove_filter(dell_laptop_i8042_filter);
backlight_device_unregister(dell_backlight_device);
dell_cleanup_rfkill();
}
--
1.6.6.1
next prev parent reply other threads:[~2010-02-26 15:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 15:18 [GIT PULL] x86 platform drivers tree Matthew Garrett
2010-02-26 15:18 ` [PATCH 01/14] MAINTAINERS: update drivers/platform/x86 information Matthew Garrett
2010-02-26 16:18 ` Thadeu Lima de Souza Cascardo
2010-02-26 16:39 ` Anisse Astier
2010-02-26 16:44 ` Anisse Astier
2010-02-26 23:58 ` Henrique de Moraes Holschuh
2010-02-26 21:53 ` Corentin Chary
2010-03-01 17:59 ` Len Brown
2010-03-01 18:02 ` Matthew Garrett
2010-03-01 18:23 ` Len Brown
2010-02-26 23:51 ` Peter Feuerer
2010-02-27 3:42 ` Jonathan Woithe
2010-02-27 4:39 ` Harald Welte
2010-02-26 15:18 ` [PATCH 02/14] compal-laptop: Add support for known Compal made Dell laptops Matthew Garrett
2010-02-26 15:18 ` [PATCH 03/14] compal-laptop: Replace sysfs support with rfkill support Matthew Garrett
2010-02-26 15:18 ` Matthew Garrett [this message]
2010-02-27 8:06 ` [PATCH 04/14] dell-laptop: Update rfkill state on kill switch Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 05/14] dell-laptop: Fix platform device unregistration Matthew Garrett
2010-02-27 8:09 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 06/14] dell-laptop: Fix small memory leak Matthew Garrett
2010-02-26 15:18 ` [PATCH 07/14] dell-laptop: Block software state changes when rfkill hard blocked Matthew Garrett
2010-02-26 15:18 ` [PATCH 08/14] dell-laptop: Blacklist machines not supporting dell-laptop Matthew Garrett
2010-02-26 15:18 ` [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical address Matthew Garrett
2010-02-27 8:11 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 10/14] dell-laptop: Pay attention to which devices the hardware switch controls Matthew Garrett
2010-02-26 15:18 ` [PATCH 11/14] classmate-laptop: use a single MODULE_DEVICE_TABLE to get correct aliases Matthew Garrett
2010-02-26 15:18 ` [PATCH 12/14] dell-laptop: Add another Dell laptop to the DMI whitelist Matthew Garrett
2010-02-26 15:18 ` [PATCH 13/14] hp-wmi: Add support for tablet rotation key Matthew Garrett
2010-02-27 8:12 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 14/14] toshiba_acpi: Add full hotkey support Matthew Garrett
2010-02-27 0:07 ` [GIT PULL] x86 platform drivers tree Henrique de Moraes Holschuh
2010-03-01 14:45 ` Matthew Garrett
2010-02-28 19:59 ` tip: origin tree build failure Ingo Molnar
2010-03-02 13:56 ` [PATCH] compal-laptop: Make it depend on CONFIG_RFKILL Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267197527-18062-5-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome