* [PATCH] acpi: sleep: fixed a brace coding style issue
@ 2010-03-10 4:56 Bruno Bigras
2010-03-31 14:46 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Bruno Bigras @ 2010-03-10 4:56 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, linux-kernel, Bruno Bigras
Fix a coding style issue.
Signed-off-by: Bruno Bigras <bigras.bruno@gmail.com>
---
drivers/acpi/sleep.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 3bde594..fc8343f 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -62,9 +62,9 @@ static int acpi_sleep_prepare(u32 acpi_state)
#ifdef CONFIG_ACPI_SLEEP
/* do we have a wakeup address for S2 and S3? */
if (acpi_state == ACPI_STATE_S3) {
- if (!acpi_wakeup_address) {
+ if (!acpi_wakeup_address)
return -EFAULT;
- }
+
acpi_set_firmware_waking_vector(
(acpi_physical_address)acpi_wakeup_address);
--
1.7.0.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] acpi: sleep: fixed a brace coding style issue
2010-03-10 4:56 [PATCH] acpi: sleep: fixed a brace coding style issue Bruno Bigras
@ 2010-03-31 14:46 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2010-03-31 14:46 UTC (permalink / raw)
To: Bruno Bigras; +Cc: lenb, linux-acpi, linux-kernel
On Tue 2010-03-09 23:56:20, Bruno Bigras wrote:
> Fix a coding style issue.
>
> Signed-off-by: Bruno Bigras <bigras.bruno@gmail.com>
While I'm not fan of {}s, this is really excessive.
...especially in a code that uses u32 to pass enums, and opencodes
typecasts.
Pavel
> ---
> drivers/acpi/sleep.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 3bde594..fc8343f 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -62,9 +62,9 @@ static int acpi_sleep_prepare(u32 acpi_state)
> #ifdef CONFIG_ACPI_SLEEP
> /* do we have a wakeup address for S2 and S3? */
> if (acpi_state == ACPI_STATE_S3) {
> - if (!acpi_wakeup_address) {
> + if (!acpi_wakeup_address)
> return -EFAULT;
> - }
> +
> acpi_set_firmware_waking_vector(
> (acpi_physical_address)acpi_wakeup_address);
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-31 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 4:56 [PATCH] acpi: sleep: fixed a brace coding style issue Bruno Bigras
2010-03-31 14:46 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®