* Patch inclusion in stable
@ 2010-03-18 11:32 Surbhi Palande
2010-03-18 12:17 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Surbhi Palande @ 2010-03-18 11:32 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: stable, Stanislaw Gruszka, John W. Linville, Stanislaw Gruszka
Hi All,
I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st
patch in the series:
commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
Author: Stanislaw Gruszka <sgruszka@redhat.com>
airo: fix setting zero length WEP key
The linux-2.6 source has another patch that adds the following line:
if (WARN_ON(keylen == 0))
>> + return -1;
This is added through the commit
6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the
2.6.32.10 stable patches. I think it should be a part of stable patches
too.
Thanks!
Warm Regards,
Surbhi.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Patch inclusion in stable
2010-03-18 11:32 Patch inclusion in stable Surbhi Palande
@ 2010-03-18 12:17 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2010-03-18 12:17 UTC (permalink / raw)
To: Surbhi Palande; +Cc: Linux Kernel Mailing List, stable, John W. Linville
On Thu, Mar 18, 2010 at 01:32:33PM +0200, Surbhi Palande wrote:
> Hi All,
>
> I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st
> patch in the series:
>
> commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>
> airo: fix setting zero length WEP key
>
> The linux-2.6 source has another patch that adds the following line:
> if (WARN_ON(keylen == 0))
> >> + return -1;
>
> This is added through the commit
> 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the
> 2.6.32.10 stable patches. I think it should be a part of stable patches
> too.
keylen == 0 is just bug and should never happen. As we are printing
calltrace in such situation user is informed of a bug. Return from
function in that case is nice, but not strictly necessary.
Cheers
Stanislaw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-18 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-18 11:32 Patch inclusion in stable Surbhi Palande
2010-03-18 12:17 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®