mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, Guenter Roeck <guenter.roeck@ericsson.com>
Subject: [PATCH][RESEND] x86: Do not write to VGA memory space if CONFIG_VGA_CONSOLE is undefined
Date: Wed, 31 Mar 2010 07:41:19 -0700	[thread overview]
Message-ID: <1270046479-4486-1-git-send-email-guenter.roeck@ericsson.com> (raw)

Current early_printk code writes into VGA memory space even
if CONFIG_VGA_CONSOLE is undefined. This can cause problems
if there is no VGA device in the system, especially if the memory
is used by another device.

Fix problem by redirecting output to early_serial_console
if CONFIG_VGA_CONSOLE is undefined.

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
Sorry if you have seen this before. I seem to have trouble with our mailer.

 arch/x86/kernel/early_printk.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index b9c830c..1942039 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -160,8 +160,16 @@ static struct console early_serial_console = {
 	.index =	-1,
 };
 
+#ifdef CONFIG_VGA_CONSOLE
+#define EARLY_CONSOLE	early_vga_console
+static const int have_vga_console = 1;
+#else
+#define EARLY_CONSOLE	early_serial_console
+static const int have_vga_console;
+#endif
+
 /* Direct interface for emergencies */
-static struct console *early_console = &early_vga_console;
+static struct console *early_console = &EARLY_CONSOLE;
 static int __initdata early_console_initialized;
 
 asmlinkage void early_printk(const char *fmt, ...)
@@ -216,7 +224,7 @@ static int __init setup_early_printk(char *buf)
 			early_serial_init(buf + 4);
 			early_console_register(&early_serial_console, keep);
 		}
-		if (!strncmp(buf, "vga", 3) &&
+		if (have_vga_console && !strncmp(buf, "vga", 3) &&
 		    boot_params.screen_info.orig_video_isVGA == 1) {
 			max_xpos = boot_params.screen_info.orig_video_cols;
 			max_ypos = boot_params.screen_info.orig_video_lines;
-- 
1.7.0.87.g0901d


             reply	other threads:[~2010-03-31 14:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 14:41 Guenter Roeck [this message]
2010-03-31 15:32 ` Pekka Enberg
2010-04-05 18:10   ` Guenter Roeck
2010-04-05 18:46     ` H. Peter Anvin
2010-04-05 20:02       ` Guenter Roeck
2010-04-05 20:25         ` H. Peter Anvin
2010-04-05 21:04           ` Guenter Roeck
2010-04-05 21:11             ` H. Peter Anvin
2010-04-05 21:15               ` H. Peter Anvin
2010-04-05 22:12               ` Guenter Roeck
2010-04-06 20:17                 ` H. Peter Anvin
2010-04-06 20:37                   ` Guenter Roeck
2010-04-19 21:02                 ` H. Peter Anvin
2010-04-20  2:21                   ` Guenter Roeck
2010-04-20  3:55                     ` H. Peter Anvin
2010-03-31 18:31 ` H. Peter Anvin
2010-03-31 19:08   ` Guenter Roeck
2010-03-31 20:05     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270046479-4486-1-git-send-email-guenter.roeck@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®