From: Guenter Roeck <guenter.roeck@ericsson.com>
To: <linux-kernel@vger.kernel.org>
Cc: <hpa@zytor.com>, <penberg@cs.helsinki.fi>, <mingo@redhat.com>,
<x86@kernel.org>, <guenter.roeck@ericsson.com>
Subject: Re: [PATCH][RESEND] x86: Do not write to VGA memory space if CONFIG_VGA_CONSOLE is undefined
Date: Mon, 5 Apr 2010 11:10:29 -0700 [thread overview]
Message-ID: <1270491029.1477.453.camel@groeck-laptop> (raw)
In-Reply-To: <84144f021003310832i3420e4c1g7396b4d1f311f393@mail.gmail.com>
On Wed, 2010-03-31 at 11:32 -0400, Pekka Enberg wrote:
> On Wed, Mar 31, 2010 at 4:41 PM, Guenter Roeck
> <guenter.roeck@ericsson.com> wrote:
> > Current early_printk code writes into VGA memory space even
> > if CONFIG_VGA_CONSOLE is undefined. This can cause problems
> > if there is no VGA device in the system, especially if the memory
> > is used by another device.
> >
> > Fix problem by redirecting output to early_serial_console
> > if CONFIG_VGA_CONSOLE is undefined.
> >
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
>
> Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
>
What will it take to get this patch into the tree ?
If there are coding style issues or some other unresolved concerns,
please let me know.
Guenter
next prev parent reply other threads:[~2010-04-05 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 14:41 Guenter Roeck
2010-03-31 15:32 ` Pekka Enberg
2010-04-05 18:10 ` Guenter Roeck [this message]
2010-04-05 18:46 ` H. Peter Anvin
2010-04-05 20:02 ` Guenter Roeck
2010-04-05 20:25 ` H. Peter Anvin
2010-04-05 21:04 ` Guenter Roeck
2010-04-05 21:11 ` H. Peter Anvin
2010-04-05 21:15 ` H. Peter Anvin
2010-04-05 22:12 ` Guenter Roeck
2010-04-06 20:17 ` H. Peter Anvin
2010-04-06 20:37 ` Guenter Roeck
2010-04-19 21:02 ` H. Peter Anvin
2010-04-20 2:21 ` Guenter Roeck
2010-04-20 3:55 ` H. Peter Anvin
2010-03-31 18:31 ` H. Peter Anvin
2010-03-31 19:08 ` Guenter Roeck
2010-03-31 20:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270491029.1477.453.camel@groeck-laptop \
--to=guenter.roeck@ericsson.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®