* [RFC][PATCH 9/9] perf top: set perf_event_attr->pmu_id
@ 2010-05-10 9:29 Lin Ming
2010-05-10 9:43 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Lin Ming @ 2010-05-10 9:29 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar
Cc: Frederic Weisbecker, eranian, Gary.Mohr@Bull.com, Corey Ashford,
arjan, Zhang, Yanmin, Paul Mackerras, David S. Miller,
Russell King, Paul Mundt, lkml
This is just a temporary patch to show the setting of
perf_event_attr->pmu_id.
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
tools/perf/builtin-top.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index ed9b5b6..f775393 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1213,6 +1213,11 @@ static void start_counter(int i, int counter)
attr = attrs + counter;
+ /*
+ * TBD: in the future, may read /sys/devices/system/cpu/pmus/<pmu_id>
+ * to get the pmu id
+ */
+ attr.pmu_id = 0;
attr->sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_TID;
if (freq) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH 9/9] perf top: set perf_event_attr->pmu_id
2010-05-10 9:29 [RFC][PATCH 9/9] perf top: set perf_event_attr->pmu_id Lin Ming
@ 2010-05-10 9:43 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2010-05-10 9:43 UTC (permalink / raw)
To: Lin Ming
Cc: Ingo Molnar, Frederic Weisbecker, eranian, Gary.Mohr@Bull.com,
Corey Ashford, arjan, Zhang, Yanmin, Paul Mackerras,
David S. Miller, Russell King, Paul Mundt, lkml
On Mon, 2010-05-10 at 17:29 +0800, Lin Ming wrote:
> This is just a temporary patch to show the setting of
> perf_event_attr->pmu_id.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> tools/perf/builtin-top.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index ed9b5b6..f775393 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1213,6 +1213,11 @@ static void start_counter(int i, int counter)
>
> attr = attrs + counter;
>
> + /*
> + * TBD: in the future, may read /sys/devices/system/cpu/pmus/<pmu_id>
> + * to get the pmu id
> + */
> + attr.pmu_id = 0;
No, cpu PMUs must always be pmu_id 0.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-10 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-10 9:29 [RFC][PATCH 9/9] perf top: set perf_event_attr->pmu_id Lin Ming
2010-05-10 9:43 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome