From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-audit@redhat.com, zippel@linux-m68k.org,
linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 1/6]scripts:conf.c Fix warning: variable 'type' set but not used
Date: Fri, 11 Jun 2010 13:41:04 -0700 [thread overview]
Message-ID: <1276288869-16815-2-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1276288869-16815-1-git-send-email-justinmattock@gmail.com>
Not sure if this is correct or not, but with
make menuconfig
HOSTCC scripts/kconfig/conf.o
scripts/kconfig/conf.c: In function 'conf_sym':
scripts/kconfig/conf.c:159:6: warning: variable 'type' set but not used
scripts/kconfig/conf.c: In function 'conf_choice':
scripts/kconfig/conf.c:231:6: warning: variable 'type' set but not used
HOSTLD scripts/kconfig/mconf
I get this using gcc 4.6.0 the below change fixes this form me.
please have a look and let me know.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
scripts/kconfig/conf.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 9960d1c..d6369e8 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -156,14 +156,12 @@ static int conf_string(struct menu *menu)
static int conf_sym(struct menu *menu)
{
struct symbol *sym = menu->sym;
- int type;
tristate oldval, newval;
while (1) {
printf("%*s%s ", indent - 1, "", _(menu->prompt->text));
if (sym->name)
printf("(%s) ", sym->name);
- type = sym_get_type(sym);
putchar('[');
oldval = sym_get_tristate_value(sym);
switch (oldval) {
@@ -228,11 +226,9 @@ static int conf_choice(struct menu *menu)
{
struct symbol *sym, *def_sym;
struct menu *child;
- int type;
bool is_new;
sym = menu->sym;
- type = sym_get_type(sym);
is_new = !sym_has_value(sym);
if (sym_is_changable(sym)) {
conf_sym(menu);
--
1.7.1.rc1.21.gf3bd6
next prev parent reply other threads:[~2010-06-11 20:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 20:41 [PATCH 0/6] Fix gcc warnings of unused variables etc Justin P. Mattock
2010-06-11 20:41 ` Justin P. Mattock [this message]
2010-06-11 22:19 ` [PATCH 1/6]scripts:conf.c Fix warning: variable 'type' set but not used Michal Marek
2010-06-11 22:24 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' " Justin P. Mattock
2010-06-11 21:14 ` Geert Uytterhoeven
2010-06-11 22:03 ` Justin P. Mattock
2010-06-19 4:45 ` Justin P. Mattock
2010-06-19 8:06 ` Geert Uytterhoeven
2010-06-19 13:29 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 3/6]cifs Fix variable not set warnings Justin P. Mattock
2010-06-20 13:22 ` Alessandro Guido
2010-06-20 13:29 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 4/6]hfs Fix variable set but not used Justin P. Mattock
2010-06-11 20:41 ` [PATCH 5/6]kernel:module.c variable 'nowarn' " Justin P. Mattock
2010-06-11 21:17 ` Geert Uytterhoeven
2010-06-11 22:06 ` Justin P. Mattock
2010-06-19 5:04 ` Justin P. Mattock
2010-06-19 8:08 ` Geert Uytterhoeven
2010-06-19 13:41 ` Justin P. Mattock
2010-06-19 19:10 ` Justin P. Mattock
2010-06-19 19:45 ` Geert Uytterhoeven
2010-06-19 20:10 ` Justin P. Mattock
2010-06-19 20:23 ` Geert Uytterhoeven
2010-06-19 20:26 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 6/6]afs:fsclient.c Fix variable 'bp' " Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276288869-16815-2-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome