From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-audit@redhat.com, zippel@linux-m68k.org,
linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 4/6]hfs Fix variable set but not used
Date: Fri, 11 Jun 2010 13:41:07 -0700 [thread overview]
Message-ID: <1276288869-16815-5-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1276288869-16815-1-git-send-email-justinmattock@gmail.com>
Im getting these warnings when compiling
(the patch below gets rid of the warning).
CC [M] fs/hfsplus/extents.o
fs/hfsplus/extents.c: In function 'hfsplus_get_block':
fs/hfsplus/extents.c:178:6: warning: variable 'shift' set but not used
CC [M] fs/hfs/bnode.o
fs/hfs/bnode.c: In function 'hfs_bnode_copy':
fs/hfs/bnode.c:100:20: warning: variable 'tree' set but not used
fs/hfs/bnode.c: In function '__hfs_bnode_create':
fs/hfs/bnode.c:238:22: warning: variable 'sb' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
fs/hfs/bnode.c | 4 ----
fs/hfsplus/extents.c | 4 +---
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c
index cdb41a1..c6e0bd2 100644
--- a/fs/hfs/bnode.c
+++ b/fs/hfs/bnode.c
@@ -97,13 +97,11 @@ void hfs_bnode_clear(struct hfs_bnode *node, int off, int len)
void hfs_bnode_copy(struct hfs_bnode *dst_node, int dst,
struct hfs_bnode *src_node, int src, int len)
{
- struct hfs_btree *tree;
struct page *src_page, *dst_page;
dprint(DBG_BNODE_MOD, "copybytes: %u,%u,%u\n", dst, src, len);
if (!len)
return;
- tree = src_node->tree;
src += src_node->page_offset;
dst += dst_node->page_offset;
src_page = src_node->page[0];
@@ -235,7 +233,6 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)
static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
{
- struct super_block *sb;
struct hfs_bnode *node, *node2;
struct address_space *mapping;
struct page *page;
@@ -247,7 +244,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
return NULL;
}
- sb = tree->inode->i_sb;
size = sizeof(struct hfs_bnode) + tree->pages_per_bnode *
sizeof(struct page *);
node = kzalloc(size, GFP_KERNEL);
diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c
index 0022eec..7b5728d 100644
--- a/fs/hfsplus/extents.c
+++ b/fs/hfsplus/extents.c
@@ -175,12 +175,10 @@ int hfsplus_get_block(struct inode *inode, sector_t iblock,
struct super_block *sb;
int res = -EIO;
u32 ablock, dblock, mask;
- int shift;
-
+
sb = inode->i_sb;
/* Convert inode block to disk allocation block */
- shift = HFSPLUS_SB(sb).alloc_blksz_shift - sb->s_blocksize_bits;
ablock = iblock >> HFSPLUS_SB(sb).fs_shift;
if (iblock >= HFSPLUS_I(inode).fs_blocks) {
--
1.7.1.rc1.21.gf3bd6
next prev parent reply other threads:[~2010-06-11 20:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 20:41 [PATCH 0/6] Fix gcc warnings of unused variables etc Justin P. Mattock
2010-06-11 20:41 ` [PATCH 1/6]scripts:conf.c Fix warning: variable 'type' set but not used Justin P. Mattock
2010-06-11 22:19 ` Michal Marek
2010-06-11 22:24 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' " Justin P. Mattock
2010-06-11 21:14 ` Geert Uytterhoeven
2010-06-11 22:03 ` Justin P. Mattock
2010-06-19 4:45 ` Justin P. Mattock
2010-06-19 8:06 ` Geert Uytterhoeven
2010-06-19 13:29 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 3/6]cifs Fix variable not set warnings Justin P. Mattock
2010-06-20 13:22 ` Alessandro Guido
2010-06-20 13:29 ` Justin P. Mattock
2010-06-11 20:41 ` Justin P. Mattock [this message]
2010-06-11 20:41 ` [PATCH 5/6]kernel:module.c variable 'nowarn' set but not used Justin P. Mattock
2010-06-11 21:17 ` Geert Uytterhoeven
2010-06-11 22:06 ` Justin P. Mattock
2010-06-19 5:04 ` Justin P. Mattock
2010-06-19 8:08 ` Geert Uytterhoeven
2010-06-19 13:41 ` Justin P. Mattock
2010-06-19 19:10 ` Justin P. Mattock
2010-06-19 19:45 ` Geert Uytterhoeven
2010-06-19 20:10 ` Justin P. Mattock
2010-06-19 20:23 ` Geert Uytterhoeven
2010-06-19 20:26 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 6/6]afs:fsclient.c Fix variable 'bp' " Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276288869-16815-5-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome