mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
	zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org,
	rusty@rustcorp.com.au
Subject: Re: [PATCH 5/6]kernel:module.c variable 'nowarn' set but not used
Date: Fri, 18 Jun 2010 22:04:30 -0700	[thread overview]
Message-ID: <4C1C4FDE.2090101@gmail.com> (raw)
In-Reply-To: <AANLkTilZLOGXpZxHUklA8iHMj8HsJap2BvWMrWMmeyu3@mail.gmail.com>


> Also wrong, you removed the creation of the links in sysfs.
>
> The assignment to nowarn was there to avoid another compiler warning,
> as sysfs_create_link() is marked __must_check.

I also went back to this one and made the following changes.. let me 
know if it's wrong etc..

 From 4f45beed80627d2bb32fb021bb6d22d88089557b Mon Sep 17 00:00:00 2001
From: Justin P. Mattock <justinmattock@gmail.com>
Date: Fri, 18 Jun 2010 22:01:07 -0700
Subject: [PATCH 5/5] module.c
  Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
  kernel/module.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 8c6b428..48fc5c8 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1340,11 +1340,10 @@ static void add_usage_links(struct module *mod)
  {
  #ifdef CONFIG_MODULE_UNLOAD
  	struct module_use *use;
-	int nowarn;

  	mutex_lock(&module_mutex);
  	list_for_each_entry(use, &mod->target_list, target_list) {
-		nowarn = sysfs_create_link(use->target->holders_dir,
+		sysfs_create_link(use->target->holders_dir,
  					   &mod->mkobj.kobj, mod->name);
  	}
  	mutex_unlock(&module_mutex);
-- 
1.7.1.rc1.21.gf3bd6

if it looks good, then I can resend it out.

Justin P. Mattock

  parent reply	other threads:[~2010-06-19  5:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11 20:41 [PATCH 0/6] Fix gcc warnings of unused variables etc Justin P. Mattock
2010-06-11 20:41 ` [PATCH 1/6]scripts:conf.c Fix warning: variable 'type' set but not used Justin P. Mattock
2010-06-11 22:19   ` Michal Marek
2010-06-11 22:24     ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' " Justin P. Mattock
2010-06-11 21:14   ` Geert Uytterhoeven
2010-06-11 22:03     ` Justin P. Mattock
2010-06-19  4:45     ` Justin P. Mattock
2010-06-19  8:06       ` Geert Uytterhoeven
2010-06-19 13:29         ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 3/6]cifs Fix variable not set warnings Justin P. Mattock
2010-06-20 13:22   ` Alessandro Guido
2010-06-20 13:29     ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 4/6]hfs Fix variable set but not used Justin P. Mattock
2010-06-11 20:41 ` [PATCH 5/6]kernel:module.c variable 'nowarn' " Justin P. Mattock
2010-06-11 21:17   ` Geert Uytterhoeven
2010-06-11 22:06     ` Justin P. Mattock
2010-06-19  5:04     ` Justin P. Mattock [this message]
2010-06-19  8:08       ` Geert Uytterhoeven
2010-06-19 13:41         ` Justin P. Mattock
2010-06-19 19:10         ` Justin P. Mattock
2010-06-19 19:45           ` Geert Uytterhoeven
2010-06-19 20:10             ` Justin P. Mattock
2010-06-19 20:23               ` Geert Uytterhoeven
2010-06-19 20:26                 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 6/6]afs:fsclient.c Fix variable 'bp' " Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1C4FDE.2090101@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome