From: Zachary Amsden <zamsden@redhat.com>
To: avi@redhat.com, mtosatti@redhat.com, glommer@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zachary Amsden <zamsden@redhat.com>
Subject: [PATCH 01/17] Eliminate duplicated timer code
Date: Mon, 14 Jun 2010 21:34:03 -1000 [thread overview]
Message-ID: <1276587259-32319-2-git-send-email-zamsden@redhat.com> (raw)
In-Reply-To: <1276587259-32319-1-git-send-email-zamsden@redhat.com>
Move duplicated timer related code into arch_vcpu_load rather
than vendor callouts. Should be an isomorphic transformation.
Signed-off-by: Zachary Amsden <zamsden@redhat.com>
---
arch/x86/kvm/svm.c | 2 --
arch/x86/kvm/vmx.c | 3 +--
arch/x86/kvm/x86.c | 4 ++++
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 2ae0c39..09b2145 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -960,8 +960,6 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
if (is_nested(svm))
svm->nested.hsave->control.tsc_offset += delta;
}
- vcpu->cpu = cpu;
- kvm_migrate_timers(vcpu);
svm->asid_generation = 0;
}
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index b1542b9..a657e08 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -898,14 +898,12 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
struct desc_ptr dt;
unsigned long sysenter_esp;
- kvm_migrate_timers(vcpu);
set_bit(KVM_REQ_TLB_FLUSH, &vcpu->requests);
local_irq_disable();
list_add(&vmx->local_vcpus_link,
&per_cpu(vcpus_on_cpu, cpu));
local_irq_enable();
- vcpu->cpu = cpu;
/*
* Linux uses per-cpu TSS and GDT, so set these when switching
* processors.
@@ -4106,6 +4104,7 @@ static struct kvm_vcpu *vmx_create_vcpu(struct kvm *kvm, unsigned int id)
cpu = get_cpu();
vmx_vcpu_load(&vmx->vcpu, cpu);
+ vmx->vcpu.cpu = cpu;
err = vmx_vcpu_setup(vmx);
vmx_vcpu_put(&vmx->vcpu);
put_cpu();
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 7a4073b..05754c1 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1799,6 +1799,9 @@ out:
void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
{
+ if (unlikely(vcpu->cpu != cpu)) {
+ kvm_migrate_timers(vcpu);
+ }
kvm_x86_ops->vcpu_load(vcpu, cpu);
if (unlikely(per_cpu(cpu_tsc_khz, cpu) == 0)) {
unsigned long khz = cpufreq_quick_get(cpu);
@@ -1807,6 +1810,7 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
per_cpu(cpu_tsc_khz, cpu) = khz;
}
kvm_request_guest_time_update(vcpu);
+ vcpu->cpu = cpu;
}
void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu)
--
1.7.1
next prev parent reply other threads:[~2010-06-15 7:34 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 7:34 TSC cleanups, fixes, documentation for KVM Zachary Amsden
2010-06-15 7:34 ` Zachary Amsden [this message]
2010-06-16 13:07 ` [PATCH 01/17] Eliminate duplicated timer code Glauber Costa
2010-06-15 7:34 ` [PATCH 02/17] Make cpu_tsc_khz updates use local CPU Zachary Amsden
2010-06-15 8:02 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 03/17] Unify vendor TSC logic Zachary Amsden
2010-06-16 8:10 ` Jason Wang
2010-06-16 13:22 ` Glauber Costa
2010-06-17 8:03 ` Jason Wang
2010-06-16 18:42 ` Zachary Amsden
2010-06-17 8:15 ` Jason Wang
2010-06-17 20:30 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 04/17] Fix deep C-state TSC desynchronization Zachary Amsden
2010-06-15 8:09 ` Avi Kivity
2010-06-15 8:14 ` Zachary Amsden
2010-06-16 8:10 ` Jason Wang
2010-06-16 18:43 ` Zachary Amsden
2010-06-16 13:24 ` Glauber Costa
2010-06-16 19:20 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 05/17] Keep SMP VMs more in sync on unstable TSC Zachary Amsden
2010-06-15 8:11 ` Avi Kivity
2010-06-16 8:11 ` Jason Wang
2010-06-16 13:32 ` Glauber Costa
2010-06-16 21:15 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 06/17] Rename KVM_REQ_KVMCLOCK_UPDATE Zachary Amsden
2010-06-15 7:34 ` [PATCH 07/17] Perform hardware_enable in CPU_STARTING callback Zachary Amsden
2010-06-15 7:34 ` [PATCH 08/17] Add clock sync request to hardware enable Zachary Amsden
2010-06-15 8:24 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 09/17] Move scale_delta into common header Zachary Amsden
2010-06-15 7:34 ` [PATCH 10/17] Make KVM clock computation work for other scales Zachary Amsden
2010-06-15 7:34 ` [PATCH 11/17] Fix a possible backwards warp of kvmclock Zachary Amsden
2010-06-15 8:40 ` Avi Kivity
2010-06-15 20:37 ` Zachary Amsden
2010-06-15 23:47 ` Marcelo Tosatti
2010-06-16 0:21 ` Zachary Amsden
2010-06-16 0:39 ` Marcelo Tosatti
2010-06-16 8:11 ` Jason Wang
2010-06-16 13:58 ` Glauber Costa
2010-06-16 14:13 ` Avi Kivity
2010-06-16 14:58 ` Glauber Costa
2010-06-16 22:38 ` Zachary Amsden
2010-06-16 19:36 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 12/17] Add helper function get_kernel_ns Zachary Amsden
2010-06-15 8:41 ` Avi Kivity
2010-06-15 21:03 ` Zachary Amsden
2010-06-15 21:13 ` john stultz
2010-06-16 8:12 ` Jason Wang
2010-06-16 14:03 ` Glauber Costa
2010-06-15 7:34 ` [PATCH 13/17] Add TSC offset tracking Zachary Amsden
2010-06-15 8:44 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 14/17] Fix SVM VMCB reset Zachary Amsden
2010-06-15 7:34 ` [PATCH 15/17] Fix AMD C1 TSC desynchronization Zachary Amsden
2010-06-15 8:47 ` Avi Kivity
2010-06-15 9:21 ` Zachary Amsden
2010-06-15 14:46 ` Roedel, Joerg
2010-06-15 7:34 ` [PATCH 16/17] TSC reset compensation Zachary Amsden
2010-06-15 8:51 ` Avi Kivity
2010-06-15 20:32 ` Zachary Amsden
2010-06-16 0:27 ` Marcelo Tosatti
2010-06-16 0:32 ` Zachary Amsden
2010-06-16 13:52 ` Glauber Costa
2010-06-16 22:36 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 17/17] Add timekeeping documentation Zachary Amsden
2010-06-15 8:51 ` Avi Kivity
2010-06-15 20:27 ` Randy Dunlap
2010-06-16 23:59 ` Zachary Amsden
2010-06-17 8:55 ` Andi Kleen
2010-06-17 21:14 ` Zachary Amsden
2010-06-18 7:49 ` Andi Kleen
2010-06-18 16:33 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276587259-32319-2-git-send-email-zamsden@redhat.com \
--to=zamsden@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®