From: Zachary Amsden <zamsden@redhat.com>
To: avi@redhat.com, mtosatti@redhat.com, glommer@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zachary Amsden <zamsden@redhat.com>
Subject: [PATCH 06/17] Rename KVM_REQ_KVMCLOCK_UPDATE
Date: Mon, 14 Jun 2010 21:34:08 -1000 [thread overview]
Message-ID: <1276587259-32319-7-git-send-email-zamsden@redhat.com> (raw)
In-Reply-To: <1276587259-32319-1-git-send-email-zamsden@redhat.com>
This bit will be used to track all clock synchronization events,
so rename it KVM_REQ_CLOCK_SYNC. Also it makes some spacing better.
As prep for using it for all synchronization, we can't skip
setting the bit in the event there is no vcpu time page.
Signed-off-by: Zachary Amsden <zamsden@redhat.com>
---
arch/x86/kvm/x86.c | 26 ++++++++++----------------
include/linux/kvm_host.h | 2 +-
2 files changed, 11 insertions(+), 17 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index b1bdf05..4b15d03 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -911,7 +911,12 @@ static void kvm_set_time_scale(uint32_t tsc_khz, struct pvclock_vcpu_time_info *
static DEFINE_PER_CPU(unsigned long, cpu_tsc_khz);
-static int kvm_write_guest_time(struct kvm_vcpu *v)
+static inline void kvm_request_guest_time_update(struct kvm_vcpu *v)
+{
+ set_bit(KVM_REQ_CLOCK_SYNC, &v->requests);
+}
+
+static int kvm_recompute_guest_time(struct kvm_vcpu *v)
{
struct timespec ts;
unsigned long flags;
@@ -925,7 +930,7 @@ static int kvm_write_guest_time(struct kvm_vcpu *v)
this_tsc_khz = get_cpu_var(cpu_tsc_khz);
put_cpu_var(cpu_tsc_khz);
if (unlikely(this_tsc_khz == 0)) {
- set_bit(KVM_REQ_KVMCLOCK_UPDATE, &v->requests);
+ kvm_request_guest_time_update(v);
return 1;
}
@@ -966,16 +971,6 @@ static int kvm_write_guest_time(struct kvm_vcpu *v)
return 0;
}
-static int kvm_request_guest_time_update(struct kvm_vcpu *v)
-{
- struct kvm_vcpu_arch *vcpu = &v->arch;
-
- if (!vcpu->time_page)
- return 0;
- set_bit(KVM_REQ_KVMCLOCK_UPDATE, &v->requests);
- return 1;
-}
-
static bool msr_mtrr_valid(unsigned msr)
{
switch (msr) {
@@ -4166,8 +4161,7 @@ static int kvmclock_cpufreq_notifier(struct notifier_block *nb, unsigned long va
kvm_for_each_vcpu(i, vcpu, kvm) {
if (vcpu->cpu != freq->cpu)
continue;
- if (!kvm_request_guest_time_update(vcpu))
- continue;
+ kvm_request_guest_time_update(vcpu);
if (vcpu->cpu != smp_processor_id())
send_ipi = 1;
}
@@ -4752,8 +4746,8 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
if (vcpu->requests) {
if (test_and_clear_bit(KVM_REQ_MIGRATE_TIMER, &vcpu->requests))
__kvm_migrate_timers(vcpu);
- if (test_and_clear_bit(KVM_REQ_KVMCLOCK_UPDATE, &vcpu->requests)) {
- r = kvm_write_guest_time(vcpu);
+ if (test_and_clear_bit(KVM_REQ_CLOCK_SYNC, &vcpu->requests)) {
+ r = kvm_recompute_guest_time(vcpu);
if (unlikely(r))
goto out;
}
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 2d96555..142d025 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -36,7 +36,7 @@
#define KVM_REQ_PENDING_TIMER 5
#define KVM_REQ_UNHALT 6
#define KVM_REQ_MMU_SYNC 7
-#define KVM_REQ_KVMCLOCK_UPDATE 8
+#define KVM_REQ_CLOCK_SYNC 8
#define KVM_REQ_KICK 9
#define KVM_REQ_DEACTIVATE_FPU 10
--
1.7.1
next prev parent reply other threads:[~2010-06-15 7:34 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 7:34 TSC cleanups, fixes, documentation for KVM Zachary Amsden
2010-06-15 7:34 ` [PATCH 01/17] Eliminate duplicated timer code Zachary Amsden
2010-06-16 13:07 ` Glauber Costa
2010-06-15 7:34 ` [PATCH 02/17] Make cpu_tsc_khz updates use local CPU Zachary Amsden
2010-06-15 8:02 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 03/17] Unify vendor TSC logic Zachary Amsden
2010-06-16 8:10 ` Jason Wang
2010-06-16 13:22 ` Glauber Costa
2010-06-17 8:03 ` Jason Wang
2010-06-16 18:42 ` Zachary Amsden
2010-06-17 8:15 ` Jason Wang
2010-06-17 20:30 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 04/17] Fix deep C-state TSC desynchronization Zachary Amsden
2010-06-15 8:09 ` Avi Kivity
2010-06-15 8:14 ` Zachary Amsden
2010-06-16 8:10 ` Jason Wang
2010-06-16 18:43 ` Zachary Amsden
2010-06-16 13:24 ` Glauber Costa
2010-06-16 19:20 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 05/17] Keep SMP VMs more in sync on unstable TSC Zachary Amsden
2010-06-15 8:11 ` Avi Kivity
2010-06-16 8:11 ` Jason Wang
2010-06-16 13:32 ` Glauber Costa
2010-06-16 21:15 ` Zachary Amsden
2010-06-15 7:34 ` Zachary Amsden [this message]
2010-06-15 7:34 ` [PATCH 07/17] Perform hardware_enable in CPU_STARTING callback Zachary Amsden
2010-06-15 7:34 ` [PATCH 08/17] Add clock sync request to hardware enable Zachary Amsden
2010-06-15 8:24 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 09/17] Move scale_delta into common header Zachary Amsden
2010-06-15 7:34 ` [PATCH 10/17] Make KVM clock computation work for other scales Zachary Amsden
2010-06-15 7:34 ` [PATCH 11/17] Fix a possible backwards warp of kvmclock Zachary Amsden
2010-06-15 8:40 ` Avi Kivity
2010-06-15 20:37 ` Zachary Amsden
2010-06-15 23:47 ` Marcelo Tosatti
2010-06-16 0:21 ` Zachary Amsden
2010-06-16 0:39 ` Marcelo Tosatti
2010-06-16 8:11 ` Jason Wang
2010-06-16 13:58 ` Glauber Costa
2010-06-16 14:13 ` Avi Kivity
2010-06-16 14:58 ` Glauber Costa
2010-06-16 22:38 ` Zachary Amsden
2010-06-16 19:36 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 12/17] Add helper function get_kernel_ns Zachary Amsden
2010-06-15 8:41 ` Avi Kivity
2010-06-15 21:03 ` Zachary Amsden
2010-06-15 21:13 ` john stultz
2010-06-16 8:12 ` Jason Wang
2010-06-16 14:03 ` Glauber Costa
2010-06-15 7:34 ` [PATCH 13/17] Add TSC offset tracking Zachary Amsden
2010-06-15 8:44 ` Avi Kivity
2010-06-15 7:34 ` [PATCH 14/17] Fix SVM VMCB reset Zachary Amsden
2010-06-15 7:34 ` [PATCH 15/17] Fix AMD C1 TSC desynchronization Zachary Amsden
2010-06-15 8:47 ` Avi Kivity
2010-06-15 9:21 ` Zachary Amsden
2010-06-15 14:46 ` Roedel, Joerg
2010-06-15 7:34 ` [PATCH 16/17] TSC reset compensation Zachary Amsden
2010-06-15 8:51 ` Avi Kivity
2010-06-15 20:32 ` Zachary Amsden
2010-06-16 0:27 ` Marcelo Tosatti
2010-06-16 0:32 ` Zachary Amsden
2010-06-16 13:52 ` Glauber Costa
2010-06-16 22:36 ` Zachary Amsden
2010-06-15 7:34 ` [PATCH 17/17] Add timekeeping documentation Zachary Amsden
2010-06-15 8:51 ` Avi Kivity
2010-06-15 20:27 ` Randy Dunlap
2010-06-16 23:59 ` Zachary Amsden
2010-06-17 8:55 ` Andi Kleen
2010-06-17 21:14 ` Zachary Amsden
2010-06-18 7:49 ` Andi Kleen
2010-06-18 16:33 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276587259-32319-7-git-send-email-zamsden@redhat.com \
--to=zamsden@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®