From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, andi.kleen@intel.com
Subject: [PATCH] Don't apply for write lock on tasklist_lock if parent doesn't ptrace other processes
Date: Thu, 15 Jul 2010 14:51:03 +0800 [thread overview]
Message-ID: <1279176663.2096.1264.camel@ymzhang.sh.intel.com> (raw)
We run some sub-cases (fork, exec, pipe, tcp, udp) of aim7 on 8-socket machine.
Perf shows write_lock_irq(&tasklist_lock) consumes more than 50% cpu time.
One hot caller is exit_ptrace. If the exiting process doesn't ptrace other
processes, kernel needn't apply for the write lock on tasklist_lock.
With below patch against kernel 2.6.35-rc5, we get more than 10% result improvement.
Signed-off-by: Zhang Yanmin <yanmin_zhang@linux.intel.com>
---
diff -Nraup linux-2.6.35-rc5/kernel/ptrace.c linux-2.6.35-rc5_ptrace/kernel/ptrace.c
--- linux-2.6.35-rc5/kernel/ptrace.c 2010-07-16 14:01:15.000000000 +0800
+++ linux-2.6.35-rc5_ptrace/kernel/ptrace.c 2010-07-16 14:03:20.000000000 +0800
@@ -331,6 +331,9 @@ void exit_ptrace(struct task_struct *tra
struct task_struct *p, *n;
LIST_HEAD(ptrace_dead);
+ if (list_empty(&tracer->ptraced))
+ return;
+
write_lock_irq(&tasklist_lock);
list_for_each_entry_safe(p, n, &tracer->ptraced, ptrace_entry) {
if (__ptrace_detach(tracer, p))
next reply other threads:[~2010-07-15 6:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 6:51 Zhang, Yanmin [this message]
2010-07-15 19:53 ` David Rientjes
2010-07-21 21:49 ` Andrew Morton
2010-07-21 22:25 ` Roland McGrath
2010-07-22 9:05 ` Oleg Nesterov
2010-07-22 19:24 ` Roland McGrath
2010-07-23 17:40 ` Oleg Nesterov
2010-07-23 8:45 ` Zhang, Yanmin
2010-07-23 17:34 ` Oleg Nesterov
2010-07-26 5:05 ` Zhang, Yanmin
2010-07-26 8:53 ` Oleg Nesterov
2010-07-26 9:40 ` Kleen, Andi
2010-07-27 1:15 ` Zhang, Yanmin
2010-07-29 15:12 ` [PATCH] ptrace: optimize exit_ptrace() for the likely case Oleg Nesterov
2010-07-29 17:40 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279176663.2096.1264.camel@ymzhang.sh.intel.com \
--to=yanmin_zhang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®