* [PATCH] USB: emi62: Delete an error message for a failed memory allocation in emi62_writememory()
@ 2017-12-06 11:52 SF Markus Elfring
0 siblings, 0 replies; only message in thread
From: SF Markus Elfring @ 2017-12-06 11:52 UTC (permalink / raw)
To: linux-usb, Felipe Balbi, Greg Kroah-Hartman, Johan Hovold
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 6 Dec 2017 12:42:20 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/usb/misc/emi62.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/emi62.c b/drivers/usb/misc/emi62.c
index 3eea60437f56..f85946731aaa 100644
--- a/drivers/usb/misc/emi62.c
+++ b/drivers/usb/misc/emi62.c
@@ -51,10 +51,9 @@ static int emi62_writememory(struct usb_device *dev, int address,
int result;
unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
- if (!buffer) {
- dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
+ if (!buffer)
return -ENOMEM;
- }
+
/* Note: usb_control_msg returns negative value on error or length of the
* data that was written! */
result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300);
--
2.15.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-12-06 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 11:52 [PATCH] USB: emi62: Delete an error message for a failed memory allocation in emi62_writememory() SF Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®