* TRACE: config warning for IRQSOFF_TRACER
@ 2010-08-21 14:52 Richard Kennedy
2010-08-31 0:47 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Richard Kennedy @ 2010-08-21 14:52 UTC (permalink / raw)
To: Steven Rostedt, Frederic Weisbecker; +Cc: lkml, Ingo Molnar
In my config with PROVE_LOCKING=n and FTRACE=y (which defaults
IRQSOFF_TRACER to y), I get the following warning from make oldconfig.
scripts/kconfig/conf --oldconfig arch/x86/Kconfig
warning: (IRQSOFF_TRACER && TRACING_SUPPORT && FTRACE &&
TRACE_IRQFLAGS_SUPPORT && !ARCH_USES_GETTIMEOFFSET) selects
TRACE_IRQFLAGS which has unmet direct dependencies (DEBUG_KERNEL &&
TRACE_IRQFLAGS_SUPPORT && PROVE_LOCKING)
The problem is that TRACE_IRQFLAGS depends on PROVE_LOCKING.
Should it select PROVE_LOCKING instead? or is there a better way to fix
this?
regards
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: TRACE: config warning for IRQSOFF_TRACER
2010-08-21 14:52 TRACE: config warning for IRQSOFF_TRACER Richard Kennedy
@ 2010-08-31 0:47 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2010-08-31 0:47 UTC (permalink / raw)
To: Richard Kennedy; +Cc: Frederic Weisbecker, lkml, Ingo Molnar
On Sat, 2010-08-21 at 15:52 +0100, Richard Kennedy wrote:
> In my config with PROVE_LOCKING=n and FTRACE=y (which defaults
> IRQSOFF_TRACER to y), I get the following warning from make oldconfig.
>
> scripts/kconfig/conf --oldconfig arch/x86/Kconfig
> warning: (IRQSOFF_TRACER && TRACING_SUPPORT && FTRACE &&
> TRACE_IRQFLAGS_SUPPORT && !ARCH_USES_GETTIMEOFFSET) selects
> TRACE_IRQFLAGS which has unmet direct dependencies (DEBUG_KERNEL &&
> TRACE_IRQFLAGS_SUPPORT && PROVE_LOCKING)
>
> The problem is that TRACE_IRQFLAGS depends on PROVE_LOCKING.
> Should it select PROVE_LOCKING instead? or is there a better way to fix
> this?
The TRACE_IRQFLAGS was originally written for lockdep, but it is now
used by Ftrace's irqsoff tracer.
I just compiled and booted with TRACE_IRQFLAGS=y and PROVE_LOCKING not
set, and it worked fine.
I think the correct patch is to remove the dependency of TRACE_IRQFLAGS
on PROVE_LOCKING.
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-31 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-21 14:52 TRACE: config warning for IRQSOFF_TRACER Richard Kennedy
2010-08-31 0:47 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®