From: Julia Lawall <julia@diku.dk>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] drivers/media/dvb/siano: Remove double test
Date: Sat, 28 Aug 2010 17:41:05 +0200 [thread overview]
Message-ID: <1283010066-20935-7-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1283010066-20935-1-git-send-email-julia@diku.dk>
The same expression is tested twice and the result is the same each time.
The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@expression@
expression E;
@@
(
* E
|| ... || E
|
* E
&& ... && E
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/media/dvb/siano/smscoreapi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index d93468c..70e3e0c 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -1511,8 +1511,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum,
u32 msgData[3]; /* keep it 3 ! */
} *pMsg;
- if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) ||
- (PinNum > MAX_GPIO_PIN_NUMBER))
+ if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER))
return -EINVAL;
totalLen = sizeof(struct SmsMsgHdr_ST) +
next prev parent reply other threads:[~2010-08-28 15:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 15:40 [PATCH 0/7] " Julia Lawall
2010-08-28 15:41 ` [PATCH 1/7] drivers/staging: " Julia Lawall
2010-08-28 15:41 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 16:10 ` David Brownell
2010-08-28 16:53 ` Julia Lawall
2010-08-28 17:11 ` Stefan Richter
2010-08-28 17:17 ` Julia Lawall
2010-08-28 18:11 ` David Brownell
2010-08-28 18:19 ` David Brownell
2010-08-28 16:37 ` Dan Carpenter
2010-08-28 16:48 ` [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-08-28 18:24 ` David Brownell
2010-09-01 10:03 ` Thomas Dahlmann
2010-08-28 16:49 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: " Julia Lawall
2010-08-28 16:50 ` Dan Carpenter
2010-08-28 20:10 ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 4/7] arch/x86/mm/kmemcheck: " Julia Lawall
2010-08-29 10:26 ` Pekka Enberg
2010-08-30 8:36 ` [tip:x86/mm] x86, kmemcheck: " tip-bot for Julia Lawall
2010-09-02 19:08 ` Vegard Nossum
2010-09-03 6:21 ` Ingo Molnar
2010-08-28 15:41 ` [PATCH 5/7] drivers/regulator: " Julia Lawall
2010-08-29 13:06 ` Mark Brown
2010-08-28 15:41 ` Julia Lawall [this message]
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283010066-20935-7-git-send-email-julia@diku.dk \
--to=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®