mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Julia Lawall <julia@diku.dk>
Cc: David Brownell <david-b@pacbell.net>,
	Thomas Dahlmann <dahlmann.thomas@arcor.de>,
	kernel-janitors@vger.kernel.org,
	David Brownell <dbrownell@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-geode@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test
Date: Sat, 28 Aug 2010 19:11:55 +0200	[thread overview]
Message-ID: <4C79435B.2030303@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1008281852450.13508@ask.diku.dk>

Julia Lawall wrote:
> On Sat, 28 Aug 2010, David Brownell wrote:
> 
>> Please update $SUBJECT to say which driver is
>> affected;
> 
> Done.
> 
>> it's not everything in that directory,
>> and accurate GIT summaries help a lot.
> 
> Is there some sort of rule that can be followed?  For example, if the 
> patch affects only one, file, should that file be named?  What if the 
> patch affects only two files?

gitk $path or git shortlog $path, with $path being the file or directory, give
a quick impression how the resident developers call their driver or subsystem
updates.  E.g. ^USB: instead of ^drivers/usb/.

However, the committer could still adjust the title, so no drama if the patch
subject as written by a cross-tree developer looks different from those of the
usual subsystem patches.  IMO this is one of the tasks of a subsystem
maintainer.  And it is quickly enough done with a git commit --amend.

There is only a drawbackif the subject is too broad /and/ if the Cc list is
too short;  a driver developer may miss to see the submission.  The danger of
that is low though when get_maintainer.pl is used to good effect.
-- 
Stefan Richter
-=====-==-=- =--- ===--
http://arcgraph.de/sr/

  reply	other threads:[~2010-08-28 17:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 15:40 [PATCH 0/7] " Julia Lawall
2010-08-28 15:41 ` [PATCH 1/7] drivers/staging: " Julia Lawall
2010-08-28 15:41 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 16:10   ` David Brownell
2010-08-28 16:53     ` Julia Lawall
2010-08-28 17:11       ` Stefan Richter [this message]
2010-08-28 17:17         ` Julia Lawall
2010-08-28 18:11           ` David Brownell
2010-08-28 18:19         ` David Brownell
2010-08-28 16:37   ` Dan Carpenter
2010-08-28 16:48     ` [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-08-28 18:24       ` David Brownell
2010-09-01 10:03         ` Thomas Dahlmann
2010-08-28 16:49     ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: " Julia Lawall
2010-08-28 16:50   ` Dan Carpenter
2010-08-28 20:10     ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 4/7] arch/x86/mm/kmemcheck: " Julia Lawall
2010-08-29 10:26   ` Pekka Enberg
2010-08-30  8:36   ` [tip:x86/mm] x86, kmemcheck: " tip-bot for Julia Lawall
2010-09-02 19:08     ` Vegard Nossum
2010-09-03  6:21       ` Ingo Molnar
2010-08-28 15:41 ` [PATCH 5/7] drivers/regulator: " Julia Lawall
2010-08-29 13:06   ` Mark Brown
2010-08-28 15:41 ` [PATCH 6/7] drivers/media/dvb/siano: " Julia Lawall
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C79435B.2030303@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=dahlmann.thomas@arcor.de \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®