From: Julia Lawall <julia@diku.dk>
To: Dan Carpenter <error27@gmail.com>
Cc: Thomas Dahlmann <dahlmann.thomas@arcor.de>,
kernel-janitors@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-geode@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test
Date: Sat, 28 Aug 2010 18:49:15 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1008281849010.13508@ask.diku.dk> (raw)
In-Reply-To: <20100828163725.GI9832@bicker>
On Sat, 28 Aug 2010, Dan Carpenter wrote:
> On Sat, Aug 28, 2010 at 05:41:01PM +0200, Julia Lawall wrote:
> > This is a guess as to what the code should be. Perhaps something else
> > should have been tested instead.
> >
> > drivers/usb/gadget/amd5536udc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> > index 731150d..6c40c99 100644
> > --- a/drivers/usb/gadget/amd5536udc.c
> > +++ b/drivers/usb/gadget/amd5536udc.c
> > @@ -203,7 +203,7 @@ static void print_regs(struct udc *dev)
> > DBG(dev, "DMA mode = PPBNDU (packet per buffer "
> > "WITHOUT desc. update)\n");
> > dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
> > - } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
> > + } else if (use_dma && use_dma_ppb_du) {
>
>
> My guess is that "use_dma_ppb" was intended.
Thanks. I made this change.
julia
next prev parent reply other threads:[~2010-08-28 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 15:40 [PATCH 0/7] " Julia Lawall
2010-08-28 15:41 ` [PATCH 1/7] drivers/staging: " Julia Lawall
2010-08-28 15:41 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 16:10 ` David Brownell
2010-08-28 16:53 ` Julia Lawall
2010-08-28 17:11 ` Stefan Richter
2010-08-28 17:17 ` Julia Lawall
2010-08-28 18:11 ` David Brownell
2010-08-28 18:19 ` David Brownell
2010-08-28 16:37 ` Dan Carpenter
2010-08-28 16:48 ` [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-08-28 18:24 ` David Brownell
2010-09-01 10:03 ` Thomas Dahlmann
2010-08-28 16:49 ` Julia Lawall [this message]
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: " Julia Lawall
2010-08-28 16:50 ` Dan Carpenter
2010-08-28 20:10 ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 4/7] arch/x86/mm/kmemcheck: " Julia Lawall
2010-08-29 10:26 ` Pekka Enberg
2010-08-30 8:36 ` [tip:x86/mm] x86, kmemcheck: " tip-bot for Julia Lawall
2010-09-02 19:08 ` Vegard Nossum
2010-09-03 6:21 ` Ingo Molnar
2010-08-28 15:41 ` [PATCH 5/7] drivers/regulator: " Julia Lawall
2010-08-29 13:06 ` Mark Brown
2010-08-28 15:41 ` [PATCH 6/7] drivers/media/dvb/siano: " Julia Lawall
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1008281849010.13508@ask.diku.dk \
--to=julia@diku.dk \
--cc=dahlmann.thomas@arcor.de \
--cc=dbrownell@users.sourceforge.net \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®