mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] w35und: Add locking problems to TODO list
@ 2010-09-19 10:04 Pekka Enberg
  2010-09-19 21:40 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Pekka Enberg @ 2010-09-19 10:04 UTC (permalink / raw)
  To: gregkh
  Cc: linux-kernel, Pekka Enberg, Lars Lindley, Pavel Machek, Ruslan Pisarev

The w35und uses atomics such as "ThreadCount" and "FireCount" to emulate
locking in the TX paths, for example. Document this bug in the TODO list.

Cc: Lars Lindley <lindley@coyote.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
 drivers/staging/winbond/TODO |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/winbond/TODO b/drivers/staging/winbond/TODO
index 43bee56..b4c592a 100644
--- a/drivers/staging/winbond/TODO
+++ b/drivers/staging/winbond/TODO
@@ -6,6 +6,7 @@ TODO:
 	- remove unused ioctls
 	- use cfg80211 for regulatory stuff
 	- fix 4k stack problems
+	- fix locking problems (it's done using atomics...)
 
 Please send patches to Greg Kroah-Hartman <greg@kroah.com> and
 Pavel Machek <pavel@ucw.cz>
-- 
1.6.3.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] w35und: Add locking problems to TODO list
  2010-09-19 10:04 [PATCH] w35und: Add locking problems to TODO list Pekka Enberg
@ 2010-09-19 21:40 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2010-09-19 21:40 UTC (permalink / raw)
  To: Pekka Enberg; +Cc: gregkh, linux-kernel, Lars Lindley, Ruslan Pisarev

Hi!

> The w35und uses atomics such as "ThreadCount" and "FireCount" to emulate
> locking in the TX paths, for example. Document this bug in the TODO list.
> 
> Cc: Lars Lindley <lindley@coyote.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ruslan Pisarev <ruslan@rpisarev.org.ua>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
>  drivers/staging/winbond/TODO |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/winbond/TODO b/drivers/staging/winbond/TODO
> index 43bee56..b4c592a 100644
> --- a/drivers/staging/winbond/TODO
> +++ b/drivers/staging/winbond/TODO
> @@ -6,6 +6,7 @@ TODO:
>  	- remove unused ioctls
>  	- use cfg80211 for regulatory stuff
>  	- fix 4k stack problems
> +	- fix locking problems (it's done using atomics...)

Being more verbose here would be good; list all the variables or at
least structures they are in, or something...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-19 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-19 10:04 [PATCH] w35und: Add locking problems to TODO list Pekka Enberg
2010-09-19 21:40 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®