* [PATCH] usb: gadget: dummy_hcd: Fix error path
@ 2010-10-02 7:23 Rahul Ruikar
2010-10-02 14:31 ` Alan Stern
0 siblings, 1 reply; 4+ messages in thread
From: Rahul Ruikar @ 2010-10-02 7:23 UTC (permalink / raw)
To: David Brownell, Greg Kroah-Hartman, Alan Stern
Cc: linux-usb, linux-kernel, Rahul Ruikar
In function dummy_udc_probe()
call put_device() when device_register() fails.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/gadget/dummy_hcd.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index dc65462..2548091 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
dum->gadget.dev.parent = &pdev->dev;
dum->gadget.dev.release = dummy_gadget_release;
rc = device_register (&dum->gadget.dev);
- if (rc < 0)
+ if (rc < 0) {
+ put_device(&dum->gadget.dev);
return rc;
+ }
usb_get_hcd (dummy_to_hcd (dum));
--
1.7.2.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-02 7:23 [PATCH] usb: gadget: dummy_hcd: Fix error path Rahul Ruikar
@ 2010-10-02 14:31 ` Alan Stern
2010-10-02 14:38 ` Alan Stern
2010-10-02 14:46 ` Rahul Ruikar
0 siblings, 2 replies; 4+ messages in thread
From: Alan Stern @ 2010-10-02 14:31 UTC (permalink / raw)
To: Rahul Ruikar; +Cc: David Brownell, Greg Kroah-Hartman, linux-usb, linux-kernel
On Sat, 2 Oct 2010, Rahul Ruikar wrote:
> In function dummy_udc_probe()
> call put_device() when device_register() fails.
>
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
> ---
> drivers/usb/gadget/dummy_hcd.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index dc65462..2548091 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
> dum->gadget.dev.parent = &pdev->dev;
> dum->gadget.dev.release = dummy_gadget_release;
> rc = device_register (&dum->gadget.dev);
> - if (rc < 0)
> + if (rc < 0) {
> + put_device(&dum->gadget.dev);
> return rc;
> + }
>
> usb_get_hcd (dummy_to_hcd (dum));
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Similar changes are needed in net2280.c, file_storage.c and
f_mass_storage.c, probably also in goku_udc.c and langwell_udc.c.
Would you like to make them?
Alan Stern
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-02 14:31 ` Alan Stern
@ 2010-10-02 14:38 ` Alan Stern
2010-10-02 14:46 ` Rahul Ruikar
1 sibling, 0 replies; 4+ messages in thread
From: Alan Stern @ 2010-10-02 14:38 UTC (permalink / raw)
To: Rahul Ruikar; +Cc: David Brownell, Greg Kroah-Hartman, linux-usb, linux-kernel
On Sat, 2 Oct 2010, Alan Stern wrote:
> On Sat, 2 Oct 2010, Rahul Ruikar wrote:
>
> > In function dummy_udc_probe()
> > call put_device() when device_register() fails.
> >
> > Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
> > ---
> > drivers/usb/gadget/dummy_hcd.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> > index dc65462..2548091 100644
> > --- a/drivers/usb/gadget/dummy_hcd.c
> > +++ b/drivers/usb/gadget/dummy_hcd.c
> > @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
> > dum->gadget.dev.parent = &pdev->dev;
> > dum->gadget.dev.release = dummy_gadget_release;
> > rc = device_register (&dum->gadget.dev);
> > - if (rc < 0)
> > + if (rc < 0) {
> > + put_device(&dum->gadget.dev);
> > return rc;
> > + }
> >
> > usb_get_hcd (dummy_to_hcd (dum));
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
I take this back. The call usb_get_hcd needs to be moved up before the
device_register (maybe to the start of the function.) Otherwise
dummy_gadget_release would do an unbalanced usb_put_hcd.
Alan Stern
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-02 14:31 ` Alan Stern
2010-10-02 14:38 ` Alan Stern
@ 2010-10-02 14:46 ` Rahul Ruikar
1 sibling, 0 replies; 4+ messages in thread
From: Rahul Ruikar @ 2010-10-02 14:46 UTC (permalink / raw)
To: Alan Stern; +Cc: David Brownell, Greg Kroah-Hartman, linux-usb, linux-kernel
On 2 October 2010 20:01, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Sat, 2 Oct 2010, Rahul Ruikar wrote:
>
>> In function dummy_udc_probe()
>> call put_device() when device_register() fails.
>>
>> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
>> ---
>> drivers/usb/gadget/dummy_hcd.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
>> index dc65462..2548091 100644
>> --- a/drivers/usb/gadget/dummy_hcd.c
>> +++ b/drivers/usb/gadget/dummy_hcd.c
>> @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
>> dum->gadget.dev.parent = &pdev->dev;
>> dum->gadget.dev.release = dummy_gadget_release;
>> rc = device_register (&dum->gadget.dev);
>> - if (rc < 0)
>> + if (rc < 0) {
>> + put_device(&dum->gadget.dev);
>> return rc;
>> + }
>>
>> usb_get_hcd (dummy_to_hcd (dum));
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Similar changes are needed in net2280.c, file_storage.c and
> f_mass_storage.c, probably also in goku_udc.c and langwell_udc.c.
> Would you like to make them?
>
yes Alan, I am aware of changes needed in these files. actually there
are many other changes needed for these files ( apart from
device_register() failure.. ) I am working on these files. also this
current patch need some updates.
Thanks,
Rahul
> Alan Stern
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-02 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-02 7:23 [PATCH] usb: gadget: dummy_hcd: Fix error path Rahul Ruikar
2010-10-02 14:31 ` Alan Stern
2010-10-02 14:38 ` Alan Stern
2010-10-02 14:46 ` Rahul Ruikar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®