Re: bug in streamline_config.pl

Re: bug in streamline_config.pl

[Steven Rostedt]

On Mon, 2010-10-25 at 16:05 -0400, member graysky wrote:
> Hey man.  If I use it the way you suggested, it doesn't work.  I
> documented it in this thread:
> 
> https://bbs.archlinux.org/viewtopic.php?pid=830221#p830221
> 
> Please let me know what you think.  Note that it works perfectly call
> it without the make localmodconfig

Then this is a bug and should be reported. I've add LKML to the Cc list,
so that this becomes public for all kernel developers.

I'm a bit confused to exactly what is broken? What did you do on what
kernel and what did you find that broke?

Could you try the lastest stable kernel and see if it is broken there
too? 2.6.36.

Thanks!

-- Steve

Re: bug in streamline_config.pl

[Steven Rostedt]

On Mon, 2010-10-25 at 17:29 -0400, member graysky wrote:
> Glad to Steve.
> 
> Just did it to 2.26.36.  I repeated the build that is detailed in that
> archlinux thread.  Again, there are TONS of modules in the thing when
> I only had 93 probed.  I know some are dependencies, but if I contrast
> that number to the number that got built by calling your script
> manually, it is far less. 
> 
> Glad to provide details upon request, but everything is in that
> thread:
> 
> https://bbs.archlinux.org/viewtopic.php?pid=830221
> 
Yes, I've seen the thread, and have even commented on it a while back.
But I'm not much for web site comments for debugging. I prefer LKML
email. ;-)

I've read it and I'm still not sure what you deem is broken. By running
the script directly, you will not process any Kconfigs. This means that
dependencies are not processed. This was what the original
streamline_config.pl did, until I received bug reports about it
producing non booting kernels.

Also, make localmodconfig will search for a .config to use if one is not
present. You do not need to copy over one.

Could you send me the output of lsmod, and the .config you started with,
and I can tell you why it selected what it did.

BTW, you can use lsmods from various boxes by doing:

 (on another box) $ lsmod > mymod
                  $ scp mymod myhost:/tmp/


 (on your myhost) $ make LSMOD=/tmp/mymod localmodconfig

and it will use the modules in the file mymod over the local lsmod.


-- Steve

Re: bug in streamline_config.pl

[Steven Rostedt]

OK, you just found a bug ;-)

You complained about CONFIG_DRM_RADEON being selected (that's ATI
Radean). Here's why:

CONFIG_DRM_RADEON select by dependency on HWMON
CONFIG_HWMON_VID selected by direct module hwmon_vid

You had hwmon_vid enabled. This module gets selected by other modules,
one being DRM_RADEON.

If a module is selected by other modules and does not have a prompt to
select itself, then I have to select the other modules because I don't
know what module is needed to make sure this module is selected (again,
I can add logic to see if the select is satisfied by the direct
selections).

But, (here's the bug) HWMON has a prompt!  But it's a different kind of
prompt. It's a menuconfig option and not a config option. By making this
one-liner fix, I just removed the following options from your config:

 CONFIG_HOTPLUG_PCI=m
 CONFIG_RFKILL=m
 CONFIG_SFC=m
 CONFIG_DRM=m
 CONFIG_DRM_KMS_HELPER=m
 CONFIG_DRM_RADEON=m
 CONFIG_DRM_I915=m
 CONFIG_FB_DDC=m
 CONFIG_FB_NVIDIA=m
 CONFIG_FB_RIVA=m
 CONFIG_FB_RADEON=m
 CONFIG_FB_SAVAGE=m
 CONFIG_FB_3DFX=m
 CONFIG_DRM_NOUVEAU=m
 CONFIG_THINKPAD_ACPI=m
 CONFIG_EEEPC_LAPTOP=m

I'll go ahead and make sure that this fix makes it into 2.6.37

-- Steve