[PATCH] ASoC: nuc900-ac97: fix a memory leak

[PATCH] ASoC: nuc900-ac97: fix a memory leak

[Axel Lin]

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/nuc900/nuc900-ac97.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index 293dc74..e00e39d 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -384,7 +384,6 @@ out0:
 
 static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
 {
-
 	snd_soc_unregister_dai(&pdev->dev);
 
 	clk_put(nuc900_ac97_data->clk);
@@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
 	release_mem_region(nuc900_ac97_data->res->start,
 				resource_size(nuc900_ac97_data->res));
 
+	kfree(nuc900_ac97_data);
 	nuc900_ac97_data = NULL;
 
 	return 0;
-- 
1.7.2

Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

[Liam Girdwood]

On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  sound/soc/nuc900/nuc900-ac97.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
> index 293dc74..e00e39d 100644
> --- a/sound/soc/nuc900/nuc900-ac97.c
> +++ b/sound/soc/nuc900/nuc900-ac97.c
> @@ -384,7 +384,6 @@ out0:
>  
>  static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>  {
> -
>  	snd_soc_unregister_dai(&pdev->dev);
>  
>  	clk_put(nuc900_ac97_data->clk);
> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>  	release_mem_region(nuc900_ac97_data->res->start,
>  				resource_size(nuc900_ac97_data->res));
>  
> +	kfree(nuc900_ac97_data);
>  	nuc900_ac97_data = NULL;
>  
>  	return 0;


Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

[Wan ZongShun]

2010/11/24 Liam Girdwood <lrg@slimlogic.co.uk>:
> On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> ---
>>  sound/soc/nuc900/nuc900-ac97.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
>> index 293dc74..e00e39d 100644
>> --- a/sound/soc/nuc900/nuc900-ac97.c
>> +++ b/sound/soc/nuc900/nuc900-ac97.c
>> @@ -384,7 +384,6 @@ out0:
>>
>>  static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>  {
>> -
>>       snd_soc_unregister_dai(&pdev->dev);
>>
>>       clk_put(nuc900_ac97_data->clk);
>> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>       release_mem_region(nuc900_ac97_data->res->start,
>>                               resource_size(nuc900_ac97_data->res));
>>
>> +     kfree(nuc900_ac97_data);
>>       nuc900_ac97_data = NULL;
>>
>>       return 0;
>
>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

Acked-by: Wan ZongShun <mcuos.com@gmail.com>

thanks!

> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>



-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com

Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

[Mark Brown]

On Wed, Nov 24, 2010 at 04:44:23PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied, thanks.