* [PATCH] reiserfs: Don't acquire lock recursively in reiserfs_acl_chmod
@ 2010-11-30 21:09 Frederic Weisbecker
0 siblings, 0 replies; only message in thread
From: Frederic Weisbecker @ 2010-11-30 21:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, Frederic Weisbecker, Jeff Mahoney, 2.6.32.x
reiserfs_acl_chmod() can be called by reiserfs_set_attr() and then
take the reiserfs lock a second time. Thereafter it may call
journal_begin() that definetly requires the lock not to be nested
in order to release it before taking the journal mutex because
the reiserfs lock depends on the journal mutex already.
So, prevent from nesting the lock in reiserfs_acl_chmod().
Reported-by: Pawel Zawora <pzawora@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Tested-by: Pawel Zawora <pzawora@gmail.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: 2.6.32.x <stable@kernel.org>
---
fs/reiserfs/xattr_acl.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c
index 536d697..90d2fcb 100644
--- a/fs/reiserfs/xattr_acl.c
+++ b/fs/reiserfs/xattr_acl.c
@@ -472,7 +472,9 @@ int reiserfs_acl_chmod(struct inode *inode)
struct reiserfs_transaction_handle th;
size_t size = reiserfs_xattr_nblocks(inode,
reiserfs_acl_size(clone->a_count));
- reiserfs_write_lock(inode->i_sb);
+ int depth;
+
+ depth = reiserfs_write_lock_once(inode->i_sb);
error = journal_begin(&th, inode->i_sb, size * 2);
if (!error) {
int error2;
@@ -482,7 +484,7 @@ int reiserfs_acl_chmod(struct inode *inode)
if (error2)
error = error2;
}
- reiserfs_write_unlock(inode->i_sb);
+ reiserfs_write_unlock_once(inode->i_sb, depth);
}
posix_acl_release(clone);
return error;
--
1.7.3.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-11-30 21:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-30 21:09 [PATCH] reiserfs: Don't acquire lock recursively in reiserfs_acl_chmod Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®