From: Jan Kiszka <jan.kiszka@siemens.com>
To: Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Udit Kumar <u-kumar1@ti.com>
Subject: Re: [PATCH 10/12] arm64: dts: ti: k3-am65-iot*: Fixup reference to phandles array
Date: Sat, 3 Jun 2023 18:41:25 +0200 [thread overview]
Message-ID: <12c60b4a-6c1b-ce99-6828-8ab3854bb415@siemens.com> (raw)
In-Reply-To: <20230601152636.858553-11-nm@ti.com>
On 01.06.23 17:26, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 17 ++++++++---------
> .../dts/ti/k3-am6548-iot2050-advanced-m2.dts | 18 ++++++++----------
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 6b052a0ecfa1..bbbb5c169ccc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -384,13 +384,12 @@ &main_gpio0 {
>
> &wkup_gpio0 {
> pinctrl-names = "default";
> - pinctrl-0 = <
> - &arduino_io_d2_to_d3_pins_default
> - &arduino_i2c_aio_switch_pins_default
> - &arduino_io_oe_pins_default
> - &push_button_pins_default
> - &db9_com_mode_pins_default
> - >;
> + pinctrl-0 =
> + <&arduino_io_d2_to_d3_pins_default>,
> + <&arduino_i2c_aio_switch_pins_default>,
> + <&arduino_io_oe_pins_default>,
> + <&push_button_pins_default>,
> + <&db9_com_mode_pins_default>;
> gpio-line-names =
> /* 0..9 */
> "wkup_gpio0-base", "", "", "", "UART0-mode1", "UART0-mode0",
> @@ -711,11 +710,11 @@ mbox_mcu_r5fss0_core1: mbox-mcu-r5fss0-core1 {
> &mcu_r5fss0_core0 {
> memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
> <&mcu_r5fss0_core0_memory_region>;
> - mboxes = <&mailbox0_cluster0 &mbox_mcu_r5fss0_core0>;
> + mboxes = <&mailbox0_cluster0>, <&mbox_mcu_r5fss0_core0>;
> };
>
> &mcu_r5fss0_core1 {
> memory-region = <&mcu_r5fss0_core1_dma_memory_region>,
> <&mcu_r5fss0_core1_memory_region>;
> - mboxes = <&mailbox0_cluster1 &mbox_mcu_r5fss0_core1>;
> + mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> index d5e41bdc89c3..1fc93e0b3c9b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> @@ -66,20 +66,18 @@ AM65X_IOPAD(0x001c, PIN_INPUT_PULLUP, 7) /* (C23) GPIO1_89 */
>
> &main_gpio0 {
> pinctrl-names = "default";
> - pinctrl-0 = <
> - &main_m2_pcie_mux_control
> - &arduino_io_d4_to_d9_pins_default
> - >;
> + pinctrl-0 =
> + <&main_m2_pcie_mux_control>,
> + <&arduino_io_d4_to_d9_pins_default>;
> };
>
> &main_gpio1 {
> pinctrl-names = "default";
> - pinctrl-0 = <
> - &main_m2_enable_pins_default
> - &main_pmx0_m2_config_pins_default
> - &main_pmx1_m2_config_pins_default
> - &cp2102n_reset_pin_default
> - >;
> + pinctrl-0 =
> + <&main_m2_enable_pins_default>,
> + <&main_pmx0_m2_config_pins_default>,
> + <&main_pmx1_m2_config_pins_default>,
> + <&cp2102n_reset_pin_default>;
> };
>
> /*
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
next prev parent reply other threads:[~2023-06-03 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 15:26 [PATCH 00/12] arm64: dts: ti: Fix up references to phandles Nishanth Menon
2023-06-01 15:26 ` [PATCH 01/12] arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array Nishanth Menon
2023-06-01 15:26 ` [PATCH 02/12] arm64: dts: ti: k3-j721e-som-p0/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: " Nishanth Menon
2023-06-05 17:01 ` Kumar, Udit
2023-06-05 20:49 ` Nishanth Menon
2023-06-06 4:26 ` Kumar, Udit
2023-06-06 11:41 ` Nishanth Menon
2023-06-06 14:27 ` Robert Nelson
2023-06-01 15:26 ` [PATCH 04/12] arm64: dts: ti: k3-am642-phyboard-electra-rdk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 05/12] arm64: dts: ti: k3-j7200-som/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 06/12] arm64: dts: ti: k3-j721s2-common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 07/12] arm64: dts: ti: k3-am625-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 08/12] arm64: dts: ti: k3-am64-evm: " Nishanth Menon
2023-06-05 17:02 ` Kumar, Udit
2023-06-05 20:50 ` Nishanth Menon
2023-06-01 15:26 ` [PATCH 09/12] arm64: dts: ti: k3-am64-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 10/12] arm64: dts: ti: k3-am65-iot*: " Nishanth Menon
2023-06-03 16:41 ` Jan Kiszka [this message]
2023-06-01 15:26 ` [PATCH 11/12] arm64: dts: ti: k3-am654-base-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 12/12] arm64: dts: ti: k3-am68-sk-base-board: " Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c60b4a-6c1b-ce99-6828-8ab3854bb415@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®