From: "Kumar, Udit" <u-kumar1@ti.com>
To: Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles array
Date: Mon, 5 Jun 2023 22:31:17 +0530 [thread overview]
Message-ID: <f1e54167-15bd-8a0b-454d-53b90b18a343@ti.com> (raw)
In-Reply-To: <20230601152636.858553-4-nm@ti.com>
Hi Nishanth
On 6/1/2023 8:56 PM, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> Cc: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> .../boot/dts/ti/k3-j721e-beagleboneai64.dts | 29 ++++++++++---------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 37c24b077b6a..c13246a9ed8f 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -593,7 +593,7 @@ &main_i2c0 {
> &main_i2c1 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&main_i2c1_pins_default &csi1_gpio_pins_default>;
> + pinctrl-0 = <&main_i2c1_pins_default>, <&csi1_gpio_pins_default>;
> clock-frequency = <400000>;
> };
>
> @@ -623,7 +623,7 @@ &main_i2c4 {
> &main_i2c5 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&main_i2c5_pins_default &csi0_gpio_pins_default>;
> + pinctrl-0 = <&main_i2c5_pins_default>, <&csi0_gpio_pins_default>;
> clock-frequency = <400000>;
> };
>
> @@ -639,7 +639,7 @@ &main_i2c6 {
> &wkup_i2c0 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&wkup_i2c0_pins_default &eeprom_wp_pins_default>;
> + pinctrl-0 = <&wkup_i2c0_pins_default>, <&eeprom_wp_pins_default>;
> clock-frequency = <400000>;
Why we need more than 2 pio lines for i2c node ,
> [...]
>
next prev parent reply other threads:[~2023-06-05 17:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 15:26 [PATCH 00/12] arm64: dts: ti: Fix up references to phandles Nishanth Menon
2023-06-01 15:26 ` [PATCH 01/12] arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array Nishanth Menon
2023-06-01 15:26 ` [PATCH 02/12] arm64: dts: ti: k3-j721e-som-p0/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: " Nishanth Menon
2023-06-05 17:01 ` Kumar, Udit [this message]
2023-06-05 20:49 ` Nishanth Menon
2023-06-06 4:26 ` Kumar, Udit
2023-06-06 11:41 ` Nishanth Menon
2023-06-06 14:27 ` Robert Nelson
2023-06-01 15:26 ` [PATCH 04/12] arm64: dts: ti: k3-am642-phyboard-electra-rdk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 05/12] arm64: dts: ti: k3-j7200-som/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 06/12] arm64: dts: ti: k3-j721s2-common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 07/12] arm64: dts: ti: k3-am625-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 08/12] arm64: dts: ti: k3-am64-evm: " Nishanth Menon
2023-06-05 17:02 ` Kumar, Udit
2023-06-05 20:50 ` Nishanth Menon
2023-06-01 15:26 ` [PATCH 09/12] arm64: dts: ti: k3-am64-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 10/12] arm64: dts: ti: k3-am65-iot*: " Nishanth Menon
2023-06-03 16:41 ` Jan Kiszka
2023-06-01 15:26 ` [PATCH 11/12] arm64: dts: ti: k3-am654-base-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 12/12] arm64: dts: ti: k3-am68-sk-base-board: " Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e54167-15bd-8a0b-454d-53b90b18a343@ti.com \
--to=u-kumar1@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®