mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array
Date: Mon, 5 Jun 2023 22:32:18 +0530	[thread overview]
Message-ID: <720c8c43-9a95-d7b5-3267-405ff0149eea@ti.com> (raw)
In-Reply-To: <20230601152636.858553-9-nm@ti.com>

Hi Nishanth

On 6/1/2023 8:56 PM, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index 91bdc6026d1f..fef68a778ac9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -467,8 +467,8 @@ &usb0 {
>   
>   &cpsw3g {
>   	pinctrl-names = "default";
> -	pinctrl-0 = <&rgmii1_pins_default
> -		     &rgmii2_pins_default>;
> +	pinctrl-0 = <&rgmii1_pins_default>,
> +		    <&rgmii2_pins_default>;


Please see, if  pinctrl-0 can be defined in one line, instead of two, to 
be inline with most of changes in this series.

> [..]

  reply	other threads:[~2023-06-05 17:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 15:26 [PATCH 00/12] arm64: dts: ti: Fix up references to phandles Nishanth Menon
2023-06-01 15:26 ` [PATCH 01/12] arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array Nishanth Menon
2023-06-01 15:26 ` [PATCH 02/12] arm64: dts: ti: k3-j721e-som-p0/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: " Nishanth Menon
2023-06-05 17:01   ` Kumar, Udit
2023-06-05 20:49     ` Nishanth Menon
2023-06-06  4:26       ` Kumar, Udit
2023-06-06 11:41         ` Nishanth Menon
2023-06-06 14:27         ` Robert Nelson
2023-06-01 15:26 ` [PATCH 04/12] arm64: dts: ti: k3-am642-phyboard-electra-rdk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 05/12] arm64: dts: ti: k3-j7200-som/common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 06/12] arm64: dts: ti: k3-j721s2-common-proc-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 07/12] arm64: dts: ti: k3-am625-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 08/12] arm64: dts: ti: k3-am64-evm: " Nishanth Menon
2023-06-05 17:02   ` Kumar, Udit [this message]
2023-06-05 20:50     ` Nishanth Menon
2023-06-01 15:26 ` [PATCH 09/12] arm64: dts: ti: k3-am64-sk: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 10/12] arm64: dts: ti: k3-am65-iot*: " Nishanth Menon
2023-06-03 16:41   ` Jan Kiszka
2023-06-01 15:26 ` [PATCH 11/12] arm64: dts: ti: k3-am654-base-board: " Nishanth Menon
2023-06-01 15:26 ` [PATCH 12/12] arm64: dts: ti: k3-am68-sk-base-board: " Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720c8c43-9a95-d7b5-3267-405ff0149eea@ti.com \
    --to=u-kumar1@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®