* [PATCH -next] ceph: Remove unused declarations
@ 2024-08-14 3:34 Yue Haibing
2024-08-14 11:56 ` Jeff Layton
2024-08-19 1:16 ` Xiubo Li
0 siblings, 2 replies; 4+ messages in thread
From: Yue Haibing @ 2024-08-14 3:34 UTC (permalink / raw)
To: xiubli, idryomov, mchangir, jlayton; +Cc: ceph-devel, linux-kernel, yuehaibing
These functions is never implemented and used.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
fs/ceph/mds_client.h | 3 ---
fs/ceph/super.h | 2 --
include/linux/ceph/osd_client.h | 2 --
3 files changed, 7 deletions(-)
diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
index 9bcc7f181bfe..585ab5a6d87d 100644
--- a/fs/ceph/mds_client.h
+++ b/fs/ceph/mds_client.h
@@ -559,9 +559,6 @@ extern struct ceph_mds_session *
ceph_get_mds_session(struct ceph_mds_session *s);
extern void ceph_put_mds_session(struct ceph_mds_session *s);
-extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
- struct ceph_msg *msg, int mds);
-
extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index 6e817bf1337c..c88bf53f68e9 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
struct ceph_mds_session *session);
-extern int ceph_inode_holds_cap(struct inode *inode, int mask);
-
extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
extern void __ceph_do_pending_vmtruncate(struct inode *inode);
diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
index f66f6aac74f6..d7941478158c 100644
--- a/include/linux/ceph/osd_client.h
+++ b/include/linux/ceph/osd_client.h
@@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
-extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
- struct ceph_msg *msg);
extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
struct ceph_msg *msg);
void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ceph: Remove unused declarations
2024-08-14 3:34 [PATCH -next] ceph: Remove unused declarations Yue Haibing
@ 2024-08-14 11:56 ` Jeff Layton
2024-08-16 7:34 ` Ilya Dryomov
2024-08-19 1:16 ` Xiubo Li
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2024-08-14 11:56 UTC (permalink / raw)
To: Yue Haibing, xiubli, idryomov, mchangir; +Cc: ceph-devel, linux-kernel
On Wed, 2024-08-14 at 11:34 +0800, Yue Haibing wrote:
> These functions is never implemented and used.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> fs/ceph/mds_client.h | 3 ---
> fs/ceph/super.h | 2 --
> include/linux/ceph/osd_client.h | 2 --
> 3 files changed, 7 deletions(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 9bcc7f181bfe..585ab5a6d87d 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -559,9 +559,6 @@ extern struct ceph_mds_session *
> ceph_get_mds_session(struct ceph_mds_session *s);
> extern void ceph_put_mds_session(struct ceph_mds_session *s);
>
> -extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
> - struct ceph_msg *msg, int mds);
> -
> extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
> extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
> extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 6e817bf1337c..c88bf53f68e9 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
> extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
> struct ceph_mds_session *session);
>
> -extern int ceph_inode_holds_cap(struct inode *inode, int mask);
> -
> extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
> extern void __ceph_do_pending_vmtruncate(struct inode *inode);
>
> diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> index f66f6aac74f6..d7941478158c 100644
> --- a/include/linux/ceph/osd_client.h
> +++ b/include/linux/ceph/osd_client.h
> @@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
> extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
> extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
>
> -extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
> - struct ceph_msg *msg);
> extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
> struct ceph_msg *msg);
> void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ceph: Remove unused declarations
2024-08-14 11:56 ` Jeff Layton
@ 2024-08-16 7:34 ` Ilya Dryomov
0 siblings, 0 replies; 4+ messages in thread
From: Ilya Dryomov @ 2024-08-16 7:34 UTC (permalink / raw)
To: Jeff Layton; +Cc: Yue Haibing, xiubli, mchangir, ceph-devel, linux-kernel
On Wed, Aug 14, 2024 at 1:56 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> On Wed, 2024-08-14 at 11:34 +0800, Yue Haibing wrote:
> > These functions is never implemented and used.
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> > ---
> > fs/ceph/mds_client.h | 3 ---
> > fs/ceph/super.h | 2 --
> > include/linux/ceph/osd_client.h | 2 --
> > 3 files changed, 7 deletions(-)
> >
> > diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> > index 9bcc7f181bfe..585ab5a6d87d 100644
> > --- a/fs/ceph/mds_client.h
> > +++ b/fs/ceph/mds_client.h
> > @@ -559,9 +559,6 @@ extern struct ceph_mds_session *
> > ceph_get_mds_session(struct ceph_mds_session *s);
> > extern void ceph_put_mds_session(struct ceph_mds_session *s);
> >
> > -extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
> > - struct ceph_msg *msg, int mds);
> > -
> > extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
> > extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
> > extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
> > diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> > index 6e817bf1337c..c88bf53f68e9 100644
> > --- a/fs/ceph/super.h
> > +++ b/fs/ceph/super.h
> > @@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
> > extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
> > struct ceph_mds_session *session);
> >
> > -extern int ceph_inode_holds_cap(struct inode *inode, int mask);
> > -
> > extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
> > extern void __ceph_do_pending_vmtruncate(struct inode *inode);
> >
> > diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> > index f66f6aac74f6..d7941478158c 100644
> > --- a/include/linux/ceph/osd_client.h
> > +++ b/include/linux/ceph/osd_client.h
> > @@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
> > extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
> > extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
> >
> > -extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
> > - struct ceph_msg *msg);
> > extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
> > struct ceph_msg *msg);
> > void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ceph: Remove unused declarations
2024-08-14 3:34 [PATCH -next] ceph: Remove unused declarations Yue Haibing
2024-08-14 11:56 ` Jeff Layton
@ 2024-08-19 1:16 ` Xiubo Li
1 sibling, 0 replies; 4+ messages in thread
From: Xiubo Li @ 2024-08-19 1:16 UTC (permalink / raw)
To: Yue Haibing, idryomov, mchangir, jlayton; +Cc: ceph-devel, linux-kernel
On 8/14/24 11:34, Yue Haibing wrote:
> These functions is never implemented and used.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> fs/ceph/mds_client.h | 3 ---
> fs/ceph/super.h | 2 --
> include/linux/ceph/osd_client.h | 2 --
> 3 files changed, 7 deletions(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 9bcc7f181bfe..585ab5a6d87d 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -559,9 +559,6 @@ extern struct ceph_mds_session *
> ceph_get_mds_session(struct ceph_mds_session *s);
> extern void ceph_put_mds_session(struct ceph_mds_session *s);
>
> -extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
> - struct ceph_msg *msg, int mds);
> -
> extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
> extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
> extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 6e817bf1337c..c88bf53f68e9 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
> extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
> struct ceph_mds_session *session);
>
> -extern int ceph_inode_holds_cap(struct inode *inode, int mask);
> -
> extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
> extern void __ceph_do_pending_vmtruncate(struct inode *inode);
>
> diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> index f66f6aac74f6..d7941478158c 100644
> --- a/include/linux/ceph/osd_client.h
> +++ b/include/linux/ceph/osd_client.h
> @@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
> extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
> extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
>
> -extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
> - struct ceph_msg *msg);
> extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
> struct ceph_msg *msg);
> void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-19 1:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-14 3:34 [PATCH -next] ceph: Remove unused declarations Yue Haibing
2024-08-14 11:56 ` Jeff Layton
2024-08-16 7:34 ` Ilya Dryomov
2024-08-19 1:16 ` Xiubo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®