mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] linux/string.h: Introduce streq macro.
Date: Tue, 26 Apr 2011 15:00:38 -0400	[thread overview]
Message-ID: <1303844438.18763.28.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <ae304c124297e5ca75721398f398f6d524b615d2.1303843697.git.tfransosi@gmail.com>

On Tue, 2011-04-26 at 15:49 -0300, Thiago Farina wrote:
> This macro is arguably more readable than its variants:
> - !strcmp(a, b)
> - strcmp(a, b) == 0
> 

If this is acceptable, perhaps we should push this for cleanups around
the kernel.

> Signed-off-by: Thiago Farina <tfransosi@gmail.com>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

> ---
>  include/linux/string.h |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/string.h b/include/linux/string.h
> index a716ee2..15b9602 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -134,6 +134,17 @@ extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
>  			const void *from, size_t available);
>  
>  /**
> + * streq - Are two strings equal?
> + * @a: first string
> + * @b: second string
> + *
> + * Example:
> + *	if (streq(argv[1], "--help"))
> + *		printf("%s\n", "This help");
> + */
> +#define streq(a, b) (strcmp((a), (b)) == 0)

Are the extra parenthesis around the 'a' and 'b' necessary? Anything
used in streq() would be the same as what is in strcmp(). Actually, this
may be even better to make it a static inline.

static inline int streq(const char *a, const char *b)
{
	return strcmp(a, b) == 0;
}


-- Steve

> +
> +/**
>   * strstarts - does @str start with @prefix?
>   * @str: string to examine
>   * @prefix: prefix to look for.



  reply	other threads:[~2011-04-26 19:00 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 18:49 Thiago Farina
2011-04-26 19:00 ` Steven Rostedt [this message]
2011-04-26 19:05 ` Alexey Dobriyan
2011-04-26 19:17   ` Steven Rostedt
2011-04-26 19:20     ` Alexey Dobriyan
2011-04-26 19:21       ` Thiago Farina
2011-04-26 19:37         ` Steven Rostedt
2011-04-26 19:45           ` Joe Perches
2011-04-26 19:47             ` Thiago Farina
2011-04-26 19:58               ` Steven Rostedt
2011-04-26 20:06                 ` Joe Perches
2011-04-27  8:29                 ` Miguel Ojeda
2011-04-27  8:42                   ` Geert Uytterhoeven
2011-04-27  8:49                     ` Miguel Ojeda
2011-04-27  9:04                       ` Pavel Vasilyev
2011-04-26 20:00               ` Steven Rostedt
2011-04-26 19:25       ` Steven Rostedt
2011-04-26 19:45 ` Thiago Farina
2011-04-26 19:54   ` Thiago Farina
2011-04-27 17:49   ` Steven Rostedt
2011-04-27 18:33     ` H. Peter Anvin
2011-04-27 18:51       ` Pekka Enberg
2011-04-27 19:16         ` Steven Rostedt
2011-04-27 19:26           ` Steven Rostedt
2011-04-27 19:38           ` Pekka Enberg
2011-04-27 20:04             ` Steven Rostedt
2011-04-27 20:24               ` H. Peter Anvin
2011-04-27 19:01       ` Steven Rostedt
2011-04-27 23:38       ` Ted Ts'o
2011-04-28  3:30       ` Rusty Russell
2011-04-26 20:27 ` Davidlohr Bueso
2011-04-26 20:33   ` Thiago Farina
2011-04-27  0:52 ` Ted Ts'o
2011-04-27  1:32   ` Steven Rostedt
2011-04-27  6:47   ` Christoph Hellwig
2011-04-27  8:47     ` gmack
2011-04-27 14:52       ` Ted Ts'o
2011-04-27 16:04         ` Alexey Dobriyan
2011-04-27 16:26           ` Steven Rostedt
2011-04-27  8:35 ` Mike Frysinger
2011-04-27 16:46 ` Al Viro
2011-04-27 17:07   ` Steven Rostedt
2011-04-27 21:46     ` Al Viro
2011-04-27 22:17       ` Thiago Farina
2011-04-27 22:38         ` Pavel Vasilyev
2011-04-27 22:45         ` Al Viro
2011-04-28  0:05       ` Steven Rostedt
2011-04-27 22:21     ` Thiago Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303844438.18763.28.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®