mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: gmack@innerfire.net
To: Christoph Hellwig <hch@infradead.org>
Cc: "Ted Ts'o" <tytso@mit.edu>, Thiago Farina <tfransosi@gmail.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] linux/string.h: Introduce streq macro.
Date: Wed, 27 Apr 2011 04:47:40 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1104270445210.7570@mtl.rackplans.net> (raw)
In-Reply-To: <20110427064719.GB597@infradead.org>

On Wed, 27 Apr 2011, Christoph Hellwig wrote:

> Date: Wed, 27 Apr 2011 02:47:19 -0400
> From: Christoph Hellwig <hch@infradead.org>
> To: Ted Ts'o <tytso@mit.edu>, Thiago Farina <tfransosi@gmail.com>,
>     linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
> Subject: Re: [PATCH] linux/string.h: Introduce streq macro.
> 
> On Tue, Apr 26, 2011 at 08:52:43PM -0400, Ted Ts'o wrote:
> > I don't think this is not a good idea.
> > 
> > First of all, changing 2800 instances of strcmp will induce a huge
> > amount of code churn, that will cause patches to break, etc.  And
> > whether streq() looks better is going to be very much a case of
> > personal preference.  I'm so used to !strcmp(a, b) that streq(a, b)
> > would be harder for me, just because I'm not used to it.
> > 
> > So I'd NACK a change like this to any parts of the kernel that I'm
> > maintaining.  If another people feel that way, it's not clear that
> > having two different conventions in the kernel would necessarily help...
> 
> Same here.  Diverging from standard ANSI C just for the sake of being
> different is an utterly bad idea.  strcmp might not be the most natural
> calling convention, but it's been in the wild for 30 years, and everyone
> taking a C 101 course should know about it.
> 
> And if you get it wrong and don't notice it just means your testing
> coverage sucks badly.

Knowing about it and not screwing it up are two different things. I was 
working on a project a few years ago and we made this exact change thanks 
to the backwards logic of strcmp constantly screwing people up and the bug 
count went down considerably.


	Gerhard


--
Gerhard Mack

gmack@innerfire.net

<>< As a computer I find your faith in technology amusing.

  reply	other threads:[~2011-04-27  8:57 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 18:49 Thiago Farina
2011-04-26 19:00 ` Steven Rostedt
2011-04-26 19:05 ` Alexey Dobriyan
2011-04-26 19:17   ` Steven Rostedt
2011-04-26 19:20     ` Alexey Dobriyan
2011-04-26 19:21       ` Thiago Farina
2011-04-26 19:37         ` Steven Rostedt
2011-04-26 19:45           ` Joe Perches
2011-04-26 19:47             ` Thiago Farina
2011-04-26 19:58               ` Steven Rostedt
2011-04-26 20:06                 ` Joe Perches
2011-04-27  8:29                 ` Miguel Ojeda
2011-04-27  8:42                   ` Geert Uytterhoeven
2011-04-27  8:49                     ` Miguel Ojeda
2011-04-27  9:04                       ` Pavel Vasilyev
2011-04-26 20:00               ` Steven Rostedt
2011-04-26 19:25       ` Steven Rostedt
2011-04-26 19:45 ` Thiago Farina
2011-04-26 19:54   ` Thiago Farina
2011-04-27 17:49   ` Steven Rostedt
2011-04-27 18:33     ` H. Peter Anvin
2011-04-27 18:51       ` Pekka Enberg
2011-04-27 19:16         ` Steven Rostedt
2011-04-27 19:26           ` Steven Rostedt
2011-04-27 19:38           ` Pekka Enberg
2011-04-27 20:04             ` Steven Rostedt
2011-04-27 20:24               ` H. Peter Anvin
2011-04-27 19:01       ` Steven Rostedt
2011-04-27 23:38       ` Ted Ts'o
2011-04-28  3:30       ` Rusty Russell
2011-04-26 20:27 ` Davidlohr Bueso
2011-04-26 20:33   ` Thiago Farina
2011-04-27  0:52 ` Ted Ts'o
2011-04-27  1:32   ` Steven Rostedt
2011-04-27  6:47   ` Christoph Hellwig
2011-04-27  8:47     ` gmack [this message]
2011-04-27 14:52       ` Ted Ts'o
2011-04-27 16:04         ` Alexey Dobriyan
2011-04-27 16:26           ` Steven Rostedt
2011-04-27  8:35 ` Mike Frysinger
2011-04-27 16:46 ` Al Viro
2011-04-27 17:07   ` Steven Rostedt
2011-04-27 21:46     ` Al Viro
2011-04-27 22:17       ` Thiago Farina
2011-04-27 22:38         ` Pavel Vasilyev
2011-04-27 22:45         ` Al Viro
2011-04-28  0:05       ` Steven Rostedt
2011-04-27 22:21     ` Thiago Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1104270445210.7570@mtl.rackplans.net \
    --to=gmack@innerfire.net \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tfransosi@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®