From: David Jander <david@protonic.nl>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, David Jander <david@protonic.nl>
Subject: [PATCH v5 1/5] GPIO: pca953x.c: Fix IRQ support.
Date: Tue, 14 Jun 2011 11:00:54 +0200 [thread overview]
Message-ID: <1308042058-20107-2-git-send-email-david@protonic.nl> (raw)
In-Reply-To: <1308042058-20107-1-git-send-email-david@protonic.nl>
It seems that in the normal case, IRQ_NOREQUEST needs to be explicitly
cleared, otherwise claiming the interrupt fails.
In the case of sparse interrupts, the descriptor needs to be allocated
first.
Signed-off-by: David Jander <david@protonic.nl>
---
drivers/gpio/pca953x.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index 0451d7a..5f6940a 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -474,12 +474,16 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
* this purpose.
*/
chip->irq_stat &= chip->reg_direction;
- chip->irq_base = pdata->irq_base;
mutex_init(&chip->irq_lock);
+ chip->irq_base = irq_alloc_descs(-1, pdata->irq_base, chip->gpio_chip.ngpio, -1);
+ if (chip->irq_base < 0)
+ goto out_failed;
+
for (lvl = 0; lvl < chip->gpio_chip.ngpio; lvl++) {
int irq = lvl + chip->irq_base;
+ irq_clear_status_flags(irq, IRQ_NOREQUEST);
irq_set_chip_data(irq, chip);
irq_set_chip_and_handler(irq, &pca953x_irq_chip,
handle_simple_irq);
@@ -514,8 +518,10 @@ out_failed:
static void pca953x_irq_teardown(struct pca953x_chip *chip)
{
- if (chip->irq_base != -1)
+ if (chip->irq_base != -1) {
+ irq_free_descs(chip->irq_base, chip->gpio_chip.ngpio);
free_irq(chip->client->irq, chip);
+ }
}
#else /* CONFIG_GPIO_PCA953X_IRQ */
static int pca953x_irq_setup(struct pca953x_chip *chip,
--
1.7.4.1
next prev parent reply other threads:[~2011-06-14 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 9:00 [PATCH v5 0/5] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-14 9:00 ` David Jander [this message]
2011-06-16 19:45 ` [PATCH v5 1/5] GPIO: pca953x.c: Fix IRQ support Grant Likely
2011-06-14 9:00 ` [PATCH v5 2/5] GPIO: pca953x.c: Remove dynamic platform data pointer David Jander
2011-06-16 19:45 ` Grant Likely
2011-06-14 9:00 ` [PATCH v5 3/5] GPIO: pca953x.c: Deprecate meaningless device-tree bindings David Jander
2011-06-16 19:45 ` Grant Likely
2011-06-14 9:00 ` [PATCH v5 4/5] GPIO: pca953x.c: Interrupt pin is active-low David Jander
2011-06-14 9:00 ` [PATCH v5 5/5] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308042058-20107-2-git-send-email-david@protonic.nl \
--to=david@protonic.nl \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®