mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Jander <david@protonic.nl>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, David Jander <david@protonic.nl>
Subject: [PATCH v5 5/5] GPIO: pca953x.c: Fix warning of enabled interrupts in handler
Date: Tue, 14 Jun 2011 11:00:58 +0200	[thread overview]
Message-ID: <1308042058-20107-6-git-send-email-david@protonic.nl> (raw)
In-Reply-To: <1308042058-20107-1-git-send-email-david@protonic.nl>

When using nested threaded irqs, use handle_nested_irq(). This function
does not call the chip handler, so no handler is set.

Signed-off-by: David Jander <david@protonic.nl>
---
 drivers/gpio/pca953x.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index 9bdbc16..2eceb2c 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -435,7 +435,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
 
 	do {
 		level = __ffs(pending);
-		generic_handle_irq(level + chip->irq_base);
+		handle_nested_irq(level + chip->irq_base);
 
 		pending &= ~(1 << level);
 	} while (pending);
@@ -483,8 +483,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
 
 			irq_clear_status_flags(irq, IRQ_NOREQUEST);
 			irq_set_chip_data(irq, chip);
-			irq_set_chip_and_handler(irq, &pca953x_irq_chip,
-						 handle_simple_irq);
+			irq_set_chip(irq, &pca953x_irq_chip);
+			irq_set_nested_thread(irq, true);
 #ifdef CONFIG_ARM
 			set_irq_flags(irq, IRQF_VALID);
 #else
-- 
1.7.4.1


      parent reply	other threads:[~2011-06-14  9:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  9:00 [PATCH v5 0/5] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-14  9:00 ` [PATCH v5 1/5] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-16 19:45   ` Grant Likely
2011-06-14  9:00 ` [PATCH v5 2/5] GPIO: pca953x.c: Remove dynamic platform data pointer David Jander
2011-06-16 19:45   ` Grant Likely
2011-06-14  9:00 ` [PATCH v5 3/5] GPIO: pca953x.c: Deprecate meaningless device-tree bindings David Jander
2011-06-16 19:45   ` Grant Likely
2011-06-14  9:00 ` [PATCH v5 4/5] GPIO: pca953x.c: Interrupt pin is active-low David Jander
2011-06-14  9:00 ` David Jander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308042058-20107-6-git-send-email-david@protonic.nl \
    --to=david@protonic.nl \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®