From: David Jander <david@protonic.nl>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, David Jander <david@protonic.nl>
Subject: [PATCH v5 4/5] GPIO: pca953x.c: Interrupt pin is active-low
Date: Tue, 14 Jun 2011 11:00:57 +0200 [thread overview]
Message-ID: <1308042058-20107-5-git-send-email-david@protonic.nl> (raw)
In-Reply-To: <1308042058-20107-1-git-send-email-david@protonic.nl>
The interrupt pin of the PCA953x is active low, and on the rising edge
no interrupt should be produced.
Signed-off-by: David Jander <david@protonic.nl>
---
drivers/gpio/pca953x.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index c28fc98..9bdbc16 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -495,8 +495,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
ret = request_threaded_irq(client->irq,
NULL,
pca953x_irq_handler,
- IRQF_TRIGGER_RISING |
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
dev_name(&client->dev), chip);
if (ret) {
dev_err(&client->dev, "failed to request irq %d\n",
--
1.7.4.1
next prev parent reply other threads:[~2011-06-14 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 9:00 [PATCH v5 0/5] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-14 9:00 ` [PATCH v5 1/5] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-16 19:45 ` Grant Likely
2011-06-14 9:00 ` [PATCH v5 2/5] GPIO: pca953x.c: Remove dynamic platform data pointer David Jander
2011-06-16 19:45 ` Grant Likely
2011-06-14 9:00 ` [PATCH v5 3/5] GPIO: pca953x.c: Deprecate meaningless device-tree bindings David Jander
2011-06-16 19:45 ` Grant Likely
2011-06-14 9:00 ` David Jander [this message]
2011-06-14 9:00 ` [PATCH v5 5/5] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308042058-20107-5-git-send-email-david@protonic.nl \
--to=david@protonic.nl \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®