From: Matthew Garrett <mjg@redhat.com>
To: x86@kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] x86: Don't use the EFI reboot method by default
Date: Wed, 6 Jul 2011 16:52:37 -0400 [thread overview]
Message-ID: <1309985557-15350-1-git-send-email-mjg@redhat.com> (raw)
Testing suggests that at least some Lenovos and some Intels will fail
to reboot via EFI, attempting to jump to an unmapped physical address.
In the long run we could handle this by providing a page table with a
1:1 mapping of physical addresses, but for now it's probably just easier
to assume that ACPI or legacy methods will be present and reboot via those.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
arch/x86/platform/efi/efi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 06f6666..4f26568 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -540,9 +540,6 @@ void __init efi_init(void)
x86_platform.set_wallclock = efi_set_rtc_mmss;
#endif
- /* Setup for EFI runtime service */
- reboot_type = BOOT_EFI;
-
#if EFI_DEBUG
print_efi_memmap();
#endif
--
1.7.5.4
next reply other threads:[~2011-07-06 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 20:52 Matthew Garrett [this message]
2011-07-07 15:08 ` [tip:x86/urgent] " tip-bot for Matthew Garrett
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
2012-12-23 21:03 ` Willy Tarreau
2012-12-23 21:11 ` Ben Hutchings
2012-12-23 23:33 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309985557-15350-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®