From: tip-bot for Matthew Garrett <mjg@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
mjg@redhat.com, hpa@zytor.com, mingo@redhat.com,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Don't use the EFI reboot method by default
Date: Thu, 7 Jul 2011 15:08:31 GMT [thread overview]
Message-ID: <tip-f70e957cda22d309c769805cbb932407a5232219@git.kernel.org> (raw)
In-Reply-To: <1309985557-15350-1-git-send-email-mjg@redhat.com>
Commit-ID: f70e957cda22d309c769805cbb932407a5232219
Gitweb: http://git.kernel.org/tip/f70e957cda22d309c769805cbb932407a5232219
Author: Matthew Garrett <mjg@redhat.com>
AuthorDate: Wed, 6 Jul 2011 16:52:37 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 7 Jul 2011 11:35:05 +0200
x86: Don't use the EFI reboot method by default
Testing suggests that at least some Lenovos and some Intels will
fail to reboot via EFI, attempting to jump to an unmapped
physical address. In the long run we could handle this by
providing a page table with a 1:1 mapping of physical addresses,
but for now it's probably just easier to assume that ACPI or
legacy methods will be present and reboot via those.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/1309985557-15350-1-git-send-email-mjg@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/platform/efi/efi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 474356b..899e393 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -504,9 +504,6 @@ void __init efi_init(void)
x86_platform.set_wallclock = efi_set_rtc_mmss;
#endif
- /* Setup for EFI runtime service */
- reboot_type = BOOT_EFI;
-
#if EFI_DEBUG
print_efi_memmap();
#endif
next prev parent reply other threads:[~2011-07-07 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 20:52 [PATCH] " Matthew Garrett
2011-07-07 15:08 ` tip-bot for Matthew Garrett [this message]
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] " Jonathan Nieder
2012-12-23 21:03 ` Willy Tarreau
2012-12-23 21:11 ` Ben Hutchings
2012-12-23 23:33 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f70e957cda22d309c769805cbb932407a5232219@git.kernel.org \
--to=mjg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome