mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Willy Tarreau <w@1wt.eu>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	stable@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
	x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	Keith Ward <keith@chaos-realm.net>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default
Date: Sun, 23 Dec 2012 21:11:36 +0000	[thread overview]
Message-ID: <1356297096.21837.27.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20121223210348.GG3263@1wt.eu>

[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]

On Sun, 2012-12-23 at 22:03 +0100, Willy Tarreau wrote:
> Hi Jonathan,
> 
> [ccing Paul for 2.6.34]
> 
> On Sun, Dec 23, 2012 at 12:59:50PM -0800, Jonathan Nieder wrote:
> > Hi Willy et al,
> > 
> > Please consider
> > 
> >   f70e957cda22 x86: Don't use the EFI reboot method by default,
> >                2011-07-06
> > 
> > for application to the 2.6.32.y and 2.6.34.y trees.  The patch was
> > applied upstream late in the 3.0 cycle, so newer kernels don't need
> > it.
> > 
> > In 2011, Keith Ward wrote[1]:
> > 
> > > When attempting to reboot my my UEFI enabled system, the system hangs when
> > > calling reboot requiring me to manually reset the system via the reset switch.
> > >
> > > Screenshot: http://twitgoo.com/29bq1c
> > 
> > Ben Hutchings writes[1]:
> > 
> > > Version: 3.0.0-1
> > >
> > > I also had this problem on my own system, but it is fixed now.
> > > I bisected the fix to:
> > >
> > > commit f70e957cda22d309c769805cbb932407a5232219
> > > Author: Matthew Garrett <mjg@redhat.com>
> > > Date:   Wed Jul 6 16:52:37 2011 -0400
> > >
> > >     x86: Don't use the EFI reboot method by default
> > >
> > > which is basically equivalent to the workaround!
> > >
> > > I'll also apply this fix to squeeze as it's so simple.
> > 
> > Keith Ward also wrote[1]:
> > 
> > > It seems as if this has recently been reported at Ubuntu's Launchpad as well:
> > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/721576
> > 
> > There are a variety of reports of the same panic at that bug on
> > 2.6.32.y-, 2.6.38.y-, and 2.6.39-based kernels.  Passing "reboot=a,w"
> > on the kernel command line avoids trouble for reporters.
> > 
> > Regards,
> > Jonathan
> > 
> > [1] http://bugs.debian.org/626022
> 
> Thanks for the detailed report. I'm queuing it now.

In 2.6.32 the relevant code is in arch/x86/kernel/efi.c.  With the
filename changed, the patch applies cleanly and works for me.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of them.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2012-12-23 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06 20:52 Matthew Garrett
2011-07-07 15:08 ` [tip:x86/urgent] " tip-bot for Matthew Garrett
2012-12-23 20:59 ` [2.6.32.y, 2.6.34.y] Re: [PATCH] " Jonathan Nieder
2012-12-23 21:03   ` Willy Tarreau
2012-12-23 21:11     ` Ben Hutchings [this message]
2012-12-23 23:33       ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356297096.21837.27.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=hpa@zytor.com \
    --cc=jrnieder@gmail.com \
    --cc=keith@chaos-realm.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=stable@vger.kernel.org \
    --cc=w@1wt.eu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®