* [PATCH] sound, hda_codec: Fix compilation warnings
@ 2011-07-22 17:40 Borislav Petkov
2011-07-22 19:25 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2011-07-22 17:40 UTC (permalink / raw)
To: Takashi Iwai, Jaroslav Kysela; +Cc: alsa-devel, LKML, Borislav Petkov
From: Borislav Petkov <borislav.petkov@amd.com>
Convert macro to an inline function to shut up gcc:
sound/pci/hda/patch_sigmatel.c: In function `stac92xx_init´:
sound/pci/hda/patch_sigmatel.c:4385:3: warning: statement with no effect
sound/pci/hda/patch_sigmatel.c: In function `stac92xx_resume´:
sound/pci/hda/patch_sigmatel.c:4925:3: warning: statement with no effect
sound/pci/hda/hda_codec.c: In function `snd_hda_mixer_amp_switch_put´:
sound/pci/hda/patch_realtek.c:4176:2: warning: statement with no effect
sound/pci/hda/hda_codec.c:2320:2: warning: statement with no effect
sound/pci/hda/patch_realtek.c: In function `alc_resume´:
sound/pci/hda/patch_realtek.c:4558:2: warning: statement with no effect
sound/pci/hda/patch_realtek.c: In function `alc269_resume´:
sound/pci/hda/patch_realtek.c:14878:2: warning: statement with no effect
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
sound/pci/hda/hda_codec.h | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
index 59c9730..79ede92 100644
--- a/sound/pci/hda/hda_codec.h
+++ b/sound/pci/hda/hda_codec.h
@@ -1005,8 +1005,12 @@ int hda_call_check_power_status(struct hda_codec *codec, hda_nid_t nid)
return codec->patch_ops.check_power_status(codec, nid);
return 0;
}
-#else
-#define hda_call_check_power_status(codec, nid) 0
+#else
+static inline
+int hda_call_check_power_status(struct hda_codec *codec, hda_nid_t nid)
+{
+ return 0;
+}
#endif
/*
--
1.7.4.rc2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sound, hda_codec: Fix compilation warnings
2011-07-22 17:40 [PATCH] sound, hda_codec: Fix compilation warnings Borislav Petkov
@ 2011-07-22 19:25 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-07-22 19:25 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Jaroslav Kysela, alsa-devel, LKML, Borislav Petkov
At Fri, 22 Jul 2011 19:40:37 +0200,
Borislav Petkov wrote:
>
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Convert macro to an inline function to shut up gcc:
>
> sound/pci/hda/patch_sigmatel.c: In function `stac92xx_init´:
> sound/pci/hda/patch_sigmatel.c:4385:3: warning: statement with no effect
> sound/pci/hda/patch_sigmatel.c: In function `stac92xx_resume´:
> sound/pci/hda/patch_sigmatel.c:4925:3: warning: statement with no effect
> sound/pci/hda/hda_codec.c: In function `snd_hda_mixer_amp_switch_put´:
> sound/pci/hda/patch_realtek.c:4176:2: warning: statement with no effect
> sound/pci/hda/hda_codec.c:2320:2: warning: statement with no effect
> sound/pci/hda/patch_realtek.c: In function `alc_resume´:
> sound/pci/hda/patch_realtek.c:4558:2: warning: statement with no effect
> sound/pci/hda/patch_realtek.c: In function `alc269_resume´:
> sound/pci/hda/patch_realtek.c:14878:2: warning: statement with no effect
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Thanks for the patch, but this was already fixed in sound git tree.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-22 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-22 17:40 [PATCH] sound, hda_codec: Fix compilation warnings Borislav Petkov
2011-07-22 19:25 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®