[PATCH] sound, hda_codec: Fix compilation warnings

[PATCH] sound, hda_codec: Fix compilation warnings

[Borislav Petkov]

From: Borislav Petkov <borislav.petkov@amd.com>

Convert macro to an inline function to shut up gcc:

sound/pci/hda/patch_sigmatel.c: In function `stac92xx_init´:
sound/pci/hda/patch_sigmatel.c:4385:3: warning: statement with no effect
sound/pci/hda/patch_sigmatel.c: In function `stac92xx_resume´:
sound/pci/hda/patch_sigmatel.c:4925:3: warning: statement with no effect
sound/pci/hda/hda_codec.c: In function `snd_hda_mixer_amp_switch_put´:
sound/pci/hda/patch_realtek.c:4176:2: warning: statement with no effect
sound/pci/hda/hda_codec.c:2320:2: warning: statement with no effect
sound/pci/hda/patch_realtek.c: In function `alc_resume´:
sound/pci/hda/patch_realtek.c:4558:2: warning: statement with no effect
sound/pci/hda/patch_realtek.c: In function `alc269_resume´:
sound/pci/hda/patch_realtek.c:14878:2: warning: statement with no effect

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 sound/pci/hda/hda_codec.h |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
index 59c9730..79ede92 100644
--- a/sound/pci/hda/hda_codec.h
+++ b/sound/pci/hda/hda_codec.h
@@ -1005,8 +1005,12 @@ int hda_call_check_power_status(struct hda_codec *codec, hda_nid_t nid)
 		return codec->patch_ops.check_power_status(codec, nid);
 	return 0;
 }
-#else	
-#define hda_call_check_power_status(codec, nid)		0
+#else
+static inline
+int hda_call_check_power_status(struct hda_codec *codec, hda_nid_t nid)
+{
+	return 0;
+}
 #endif
 
 /*
-- 
1.7.4.rc2

Re: [PATCH] sound, hda_codec: Fix compilation warnings

[Takashi Iwai]

At Fri, 22 Jul 2011 19:40:37 +0200,
Borislav Petkov wrote:
> 
> From: Borislav Petkov <borislav.petkov@amd.com>
> 
> Convert macro to an inline function to shut up gcc:
> 
> sound/pci/hda/patch_sigmatel.c: In function `stac92xx_init´:
> sound/pci/hda/patch_sigmatel.c:4385:3: warning: statement with no effect
> sound/pci/hda/patch_sigmatel.c: In function `stac92xx_resume´:
> sound/pci/hda/patch_sigmatel.c:4925:3: warning: statement with no effect
> sound/pci/hda/hda_codec.c: In function `snd_hda_mixer_amp_switch_put´:
> sound/pci/hda/patch_realtek.c:4176:2: warning: statement with no effect
> sound/pci/hda/hda_codec.c:2320:2: warning: statement with no effect
> sound/pci/hda/patch_realtek.c: In function `alc_resume´:
> sound/pci/hda/patch_realtek.c:4558:2: warning: statement with no effect
> sound/pci/hda/patch_realtek.c: In function `alc269_resume´:
> sound/pci/hda/patch_realtek.c:14878:2: warning: statement with no effect
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Thanks for the patch, but this was already fixed in sound git tree.


Takashi