[PATCH] ftrace: tracing_on to start/stop tracing

[PATCH] ftrace: tracing_on to start/stop tracing

[Geunsik Lim]

From: Geunsik Lim <geunsik.lim@samsung.com>

tracing_enabled option is deprecated.
To start/stop tracing, write to /sys/kernel/debug/tracing/tracing_on
without tracing_enabled. This patch is based on Linux 3.1.0-rc1

Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
---
 kernel/trace/trace.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index e5df02c..91abdbf 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2710,9 +2710,9 @@ static const char readme_msg[] =
 	"# cat /sys/kernel/debug/tracing/trace_options\n"
 	"noprint-parent nosym-offset nosym-addr noverbose\n"
 	"# echo print-parent > /sys/kernel/debug/tracing/trace_options\n"
-	"# echo 1 > /sys/kernel/debug/tracing/tracing_enabled\n"
+	"# echo 1 > /sys/kernel/debug/tracing/tracing_on\n"
 	"# cat /sys/kernel/debug/tracing/trace > /tmp/trace.txt\n"
-	"# echo 0 > /sys/kernel/debug/tracing/tracing_enabled\n"
+	"# echo 0 > /sys/kernel/debug/tracing/tracing_on\n"
 ;
 
 static ssize_t
-- 
1.7.3.4

Re: [PATCH] ftrace: tracing_on to start/stop tracing

[Steven Rostedt]

On Fri, 2011-08-12 at 14:30 +0900, Geunsik Lim wrote:
> From: Geunsik Lim <geunsik.lim@samsung.com>
> 
> tracing_enabled option is deprecated.
> To start/stop tracing, write to /sys/kernel/debug/tracing/tracing_on
> without tracing_enabled. This patch is based on Linux 3.1.0-rc1
> 

Ug, I thought I fixed this. OK, thanks. Maybe we can add this to 3.1, as
it is a very low risk patch and fixes something that can confuse people.

-- Steve

> Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
> ---
>  kernel/trace/trace.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index e5df02c..91abdbf 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2710,9 +2710,9 @@ static const char readme_msg[] =
>  	"# cat /sys/kernel/debug/tracing/trace_options\n"
>  	"noprint-parent nosym-offset nosym-addr noverbose\n"
>  	"# echo print-parent > /sys/kernel/debug/tracing/trace_options\n"
> -	"# echo 1 > /sys/kernel/debug/tracing/tracing_enabled\n"
> +	"# echo 1 > /sys/kernel/debug/tracing/tracing_on\n"
>  	"# cat /sys/kernel/debug/tracing/trace > /tmp/trace.txt\n"
> -	"# echo 0 > /sys/kernel/debug/tracing/tracing_enabled\n"
> +	"# echo 0 > /sys/kernel/debug/tracing/tracing_on\n"
>  ;
>  
>  static ssize_t