From: Tero Kristo <t-kristo@ti.com>
To: <linux-kernel@vger.kernel.org>
Subject: [PATCH] irq: call also chip->irq_mask from irq_disable
Date: Wed, 14 Sep 2011 11:57:55 +0300 [thread overview]
Message-ID: <1315990675-22814-1-git-send-email-t-kristo@ti.com> (raw)
Current implementation of the irq_disable only calls chip->irq_disable.
This fails to disable interrupt on some chip implementations, as there
are two alternative chip specific functions for this task,
chip->irq_disable and chip->irq_mask. Added alternative path for
chip->irq_disable also.
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
kernel/irq/chip.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index d5a3009..15597f1 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -198,10 +198,11 @@ void irq_enable(struct irq_desc *desc)
void irq_disable(struct irq_desc *desc)
{
irq_state_set_disabled(desc);
- if (desc->irq_data.chip->irq_disable) {
+ if (desc->irq_data.chip->irq_disable)
desc->irq_data.chip->irq_disable(&desc->irq_data);
- irq_state_set_masked(desc);
- }
+ else
+ desc->irq_data.chip->irq_mask(&desc->irq_data);
+ irq_state_set_masked(desc);
}
static inline void mask_ack_irq(struct irq_desc *desc)
--
1.7.4.1
Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka: Helsinki
next reply other threads:[~2011-09-14 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 8:57 Tero Kristo [this message]
2011-09-14 16:04 ` Thomas Gleixner
2011-09-14 18:01 ` Tero Kristo
2011-09-14 19:50 ` Thomas Gleixner
2011-09-15 7:22 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315990675-22814-1-git-send-email-t-kristo@ti.com \
--to=t-kristo@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®