mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tero Kristo <t-kristo@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] irq: call also chip->irq_mask from irq_disable
Date: Wed, 14 Sep 2011 18:04:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1109141757150.2723@ionos> (raw)
In-Reply-To: <1315990675-22814-1-git-send-email-t-kristo@ti.com>

On Wed, 14 Sep 2011, Tero Kristo wrote:

> Current implementation of the irq_disable only calls chip->irq_disable.
> This fails to disable interrupt on some chip implementations, as there
> are two alternative chip specific functions for this task,
> chip->irq_disable and chip->irq_mask. Added alternative path for
> chip->irq_disable also.

This does not fail to do so. It's done on purpose. We don't want to
access the interrupt chip when we can avoid it.

So we just mark the interrupt disabled and keep the line enabled.
When another interrupt happens, then the handling code checks the
disabled state of the line, masks the interrupt on the hardware level
and sets the pending bit. This is documented behaviour and not going
to change.

http://docs.blackfin.uclinux.org/kernel/generated/genericirq/ch04s03.html#Delayed_interrupt_disable

What are you trying to solve ?

Thanks,

	tglx

  reply	other threads:[~2011-09-14 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  8:57 Tero Kristo
2011-09-14 16:04 ` Thomas Gleixner [this message]
2011-09-14 18:01   ` Tero Kristo
2011-09-14 19:50     ` Thomas Gleixner
2011-09-15  7:22       ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1109141757150.2723@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®