mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tero Kristo <t-kristo@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] irq: call also chip->irq_mask from irq_disable
Date: Wed, 14 Sep 2011 21:50:19 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1109142149060.2723@ionos> (raw)
In-Reply-To: <1316023293.2355.33.camel@sokoban>

On Wed, 14 Sep 2011, Tero Kristo wrote:
> On Wed, 2011-09-14 at 18:04 +0200, Thomas Gleixner wrote:
> > What are you trying to solve ?
> 
> I was seeing a hang with a chain handler implementation that was caused
> by this delayed disable implementation, I am using a generic chip with
> irq_mask / irq_unmask. Adding this patch to the kernel fixed the hang in
> this case. There might be something wrong in my implementation of the
> chain handler itself, I'll take a look at it again and try to figure out
> another way to avoid it. I have another idea I can pursue, and based on
> some initial testing it actually seems to be working.

chained handlers are not subject to disable/enable_irq usually. Care
to share the code ?

Thanks,

	tglx

  reply	other threads:[~2011-09-14 19:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  8:57 Tero Kristo
2011-09-14 16:04 ` Thomas Gleixner
2011-09-14 18:01   ` Tero Kristo
2011-09-14 19:50     ` Thomas Gleixner [this message]
2011-09-15  7:22       ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1109142149060.2723@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®