From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 8/8] perf evlist: Fix error handling on perf_event__mmap
Date: Tue, 13 Dec 2011 00:16:57 +0900 [thread overview]
Message-ID: <1323703017-6060-9-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1323703017-6060-1-git-send-email-namhyung@gmail.com>
If mmap syscall fails for some reason, @evlist->mmap->base wil
have the value of MAP_FAILED. Since it is defined as -1, it'll
cause a subsequent munmap failure, so the original errno will
be lost. Fix it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
tools/perf/util/evlist.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 8b19e7a1e881..5b7b3eeafb8d 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -487,7 +487,9 @@ static int perf_evlist__mmap_per_cpu(struct perf_evlist *evlist, int prot, int m
out_unmap:
for (cpu = 0; cpu < evlist->cpus->nr; cpu++) {
- if (evlist->mmap[cpu].base != NULL) {
+ if (evlist->mmap[cpu].base == MAP_FAILED) {
+ evlist->mmap[cpu].base = NULL;
+ } else if (evlist->mmap[cpu].base != NULL) {
munmap(evlist->mmap[cpu].base, evlist->mmap_len);
evlist->mmap[cpu].base = NULL;
}
@@ -526,7 +528,9 @@ static int perf_evlist__mmap_per_thread(struct perf_evlist *evlist, int prot, in
out_unmap:
for (thread = 0; thread < evlist->threads->nr; thread++) {
- if (evlist->mmap[thread].base != NULL) {
+ if (evlist->mmap[thread].base == MAP_FAILED) {
+ evlist->mmap[thread].base = NULL;
+ } else if (evlist->mmap[thread].base != NULL) {
munmap(evlist->mmap[thread].base, evlist->mmap_len);
evlist->mmap[thread].base = NULL;
}
--
1.7.6
next prev parent reply other threads:[~2011-12-12 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:16 [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Namhyung Kim
2011-12-12 15:16 ` [PATCH 1/8] perf report: Document '--call-graph' for optional print_limit argument Namhyung Kim
2011-12-21 8:42 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 2/8] perf symbols: Get rid of duplicated snprintf() Namhyung Kim
2011-12-21 8:43 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 3/8] perf symbols: Fix error path on symbol__init() Namhyung Kim
2011-12-21 8:44 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 4/8] perf tools: Fix a memory leak on perf_read_values_destroy Namhyung Kim
2011-12-21 8:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 5/8] perf tools: Remove stale git headlines from top comment Namhyung Kim
2011-12-12 18:03 ` Johannes Schindelin
2011-12-12 18:13 ` Ingo Molnar
2011-12-13 13:52 ` [PATCH UPDATED " Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 6/8] perf events: Tidy up perf_event__preprocess_sample Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 7/8] perf report: Fix usage string Namhyung Kim
2011-12-29 20:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` Namhyung Kim [this message]
2011-12-12 15:22 ` [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323703017-6060-9-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®