From: tip-bot for Namhyung Kim <namhyung@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
namhyung@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] perf report: Document '--call-graph' for optional print_limit argument
Date: Wed, 21 Dec 2011 00:42:17 -0800 [thread overview]
Message-ID: <tip-6581f6e35f7d0338f699fce660adb48e863f2b59@git.kernel.org> (raw)
In-Reply-To: <1323703017-6060-2-git-send-email-namhyung@gmail.com>
Commit-ID: 6581f6e35f7d0338f699fce660adb48e863f2b59
Gitweb: http://git.kernel.org/tip/6581f6e35f7d0338f699fce660adb48e863f2b59
Author: Namhyung Kim <namhyung@gmail.com>
AuthorDate: Tue, 13 Dec 2011 00:16:50 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 20 Dec 2011 13:28:13 -0200
perf report: Document '--call-graph' for optional print_limit argument
The '--call-graph' command line option can receive undocumented optional
print_limit argument. Besides, use strtoul() to parse the option since
its type is u32.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1323703017-6060-2-git-send-email-namhyung@gmail.com
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf-report.txt | 5 +++--
tools/perf/builtin-report.c | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index dc85392..35af0dc 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -80,9 +80,10 @@ OPTIONS
--dump-raw-trace::
Dump raw trace in ASCII.
--g [type,min,order]::
+-g [type,min[,limit],order]::
--call-graph::
- Display call chains using type, min percent threshold and order.
+ Display call chains using type, min percent threshold, optional print
+ limit and order.
type can be either:
- flat: single column, linear exposure of call chains.
- graph: use a graph tree, displaying absolute overhead rates.
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index ece7c5d..b2654c9 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -407,7 +407,7 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset)
goto setup;
if (tok2[0] != 'c') {
- callchain_param.print_limit = strtod(tok2, &endptr);
+ callchain_param.print_limit = strtoul(tok2, &endptr, 0);
tok2 = strtok(NULL, ",");
if (!tok2)
goto setup;
@@ -485,8 +485,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
"regex filter to identify parent, see: '--sort parent'"),
OPT_BOOLEAN('x', "exclude-other", &symbol_conf.exclude_other,
"Only display entries with parent-match"),
- OPT_CALLBACK_DEFAULT('g', "call-graph", &report, "output_type,min_percent, call_order",
- "Display callchains using output_type (graph, flat, fractal, or none) , min percent threshold and callchain order. "
+ OPT_CALLBACK_DEFAULT('g', "call-graph", &report, "output_type,min_percent[,print_limit],call_order",
+ "Display callchains using output_type (graph, flat, fractal, or none) , min percent threshold, optional print limit and callchain order. "
"Default: fractal,0.5,callee", &parse_callchain_opt, callchain_default_opt),
OPT_BOOLEAN('G', "inverted", &report.inverted_callchain,
"alias for inverted call graph"),
next prev parent reply other threads:[~2011-12-21 8:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:16 [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Namhyung Kim
2011-12-12 15:16 ` [PATCH 1/8] perf report: Document '--call-graph' for optional print_limit argument Namhyung Kim
2011-12-21 8:42 ` tip-bot for Namhyung Kim [this message]
2011-12-12 15:16 ` [PATCH 2/8] perf symbols: Get rid of duplicated snprintf() Namhyung Kim
2011-12-21 8:43 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 3/8] perf symbols: Fix error path on symbol__init() Namhyung Kim
2011-12-21 8:44 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 4/8] perf tools: Fix a memory leak on perf_read_values_destroy Namhyung Kim
2011-12-21 8:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 5/8] perf tools: Remove stale git headlines from top comment Namhyung Kim
2011-12-12 18:03 ` Johannes Schindelin
2011-12-12 18:13 ` Ingo Molnar
2011-12-13 13:52 ` [PATCH UPDATED " Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 6/8] perf events: Tidy up perf_event__preprocess_sample Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 7/8] perf report: Fix usage string Namhyung Kim
2011-12-29 20:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 8/8] perf evlist: Fix error handling on perf_event__mmap Namhyung Kim
2011-12-12 15:22 ` [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-6581f6e35f7d0338f699fce660adb48e863f2b59@git.kernel.org \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome