From: tip-bot for Namhyung Kim <namhyung@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
namhyung@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] perf symbols: Get rid of duplicated snprintf()
Date: Wed, 21 Dec 2011 00:43:50 -0800 [thread overview]
Message-ID: <tip-2b600f9578852d12af59420011e3dadfaa58b043@git.kernel.org> (raw)
In-Reply-To: <1323703017-6060-3-git-send-email-namhyung@gmail.com>
Commit-ID: 2b600f9578852d12af59420011e3dadfaa58b043
Gitweb: http://git.kernel.org/tip/2b600f9578852d12af59420011e3dadfaa58b043
Author: Namhyung Kim <namhyung@gmail.com>
AuthorDate: Tue, 13 Dec 2011 00:16:51 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 20 Dec 2011 13:34:52 -0200
perf symbols: Get rid of duplicated snprintf()
The 'path' variable is set on a upper line, don't need to do it again.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1323703017-6060-3-git-send-email-namhyung@gmail.com
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 632b50c..e54b13d 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1757,7 +1757,7 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
struct stat st;
/*sshfs might return bad dent->d_type, so we have to stat*/
- sprintf(path, "%s/%s", dir_name, dent->d_name);
+ snprintf(path, sizeof(path), "%s/%s", dir_name, dent->d_name);
if (stat(path, &st))
continue;
@@ -1766,8 +1766,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
!strcmp(dent->d_name, ".."))
continue;
- snprintf(path, sizeof(path), "%s/%s",
- dir_name, dent->d_name);
ret = map_groups__set_modules_path_dir(mg, path);
if (ret < 0)
goto out;
@@ -1788,9 +1786,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
if (map == NULL)
continue;
- snprintf(path, sizeof(path), "%s/%s",
- dir_name, dent->d_name);
-
long_name = strdup(path);
if (long_name == NULL) {
ret = -1;
next prev parent reply other threads:[~2011-12-21 8:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:16 [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Namhyung Kim
2011-12-12 15:16 ` [PATCH 1/8] perf report: Document '--call-graph' for optional print_limit argument Namhyung Kim
2011-12-21 8:42 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 2/8] perf symbols: Get rid of duplicated snprintf() Namhyung Kim
2011-12-21 8:43 ` tip-bot for Namhyung Kim [this message]
2011-12-12 15:16 ` [PATCH 3/8] perf symbols: Fix error path on symbol__init() Namhyung Kim
2011-12-21 8:44 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 4/8] perf tools: Fix a memory leak on perf_read_values_destroy Namhyung Kim
2011-12-21 8:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 5/8] perf tools: Remove stale git headlines from top comment Namhyung Kim
2011-12-12 18:03 ` Johannes Schindelin
2011-12-12 18:13 ` Ingo Molnar
2011-12-13 13:52 ` [PATCH UPDATED " Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 6/8] perf events: Tidy up perf_event__preprocess_sample Namhyung Kim
2011-12-21 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 7/8] perf report: Fix usage string Namhyung Kim
2011-12-29 20:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2011-12-12 15:16 ` [PATCH 8/8] perf evlist: Fix error handling on perf_event__mmap Namhyung Kim
2011-12-12 15:22 ` [PATCH -tip:perf/core 0/8] random tiny perf fixes and cleanups Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2b600f9578852d12af59420011e3dadfaa58b043@git.kernel.org \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome