mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
To: Borislav Petkov <bp@alien8.de>, Michal Simek <michal.simek@amd.com>
Cc: "Veggalam, Rama Devi" <rama.devi.veggalam@amd.com>,
	"Ghannam, Yazen" <Yazen.Ghannam@amd.com>,
	Rob Herring <robh@kernel.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"rric@kernel.org" <rric@kernel.org>,
	"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: edac: xlnx,versal-ddrmc: Add xlnx,versal-xilsem compatible
Date: Mon, 2 Nov 2026 12:35:55 +0530	[thread overview]
Message-ID: <133548dd-21de-4400-9acb-a424df75c90c@linux.microsoft.com> (raw)
In-Reply-To: <20261029152549.GBauNlfeOlTwktwjYs@fat_crate.local>

Hi Rama Devi,
>> XILSEM edac device is present on Versal and Versal NET SOCs.
>> https://docs.amd.com/r/en-US/oslib_rm/Tool-Configuration-for-XilSEM
>> (Actually also on Versal Gen 2 but firmware interface is going to be different).
>>
>> I don't think we should try to integrate EDAC memory controller with EDAC
>> device because their usage is independent of each other.
> 
> Are you saying that you will have this XILSEM hw in different platforms?
> 
> IOW, you will have a Versal or Versalnet thing and then something else, and
> then XILSEM will be in all of them?
> 
> Then perhaps it is better to have it as a separate EDAC "driver". In air
> quotes because this is not really a driver but simply a wrapper so that it can
> be called an EDAC driver.
> 
> It all depends on what hw configurations will be built.

The v2 [1] had a separate XilSEM EDAC driver. Are you planning to revive 
this?
> But if you have XILSEM *only* with Versal, then I don't want a separate EDAC,
> hm, driver.
> 
1. 
https://lore.kernel.org/lkml/20250722160315.2979294-1-rama.devi.veggalam@amd.com/

Thanks,
Prasanna

  parent reply	other threads:[~2026-11-02  7:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 12:57 [PATCH v4 0/3] EDAC/versal: Add XilSEM CRAM/NPI error monitoring support Rama devi Veggalam
2026-10-21 12:57 ` [PATCH v4 1/3] dt-bindings: edac: xlnx,versal-ddrmc: Add xlnx,versal-xilsem compatible Rama devi Veggalam
2026-10-22 14:37   ` Rob Herring
2026-10-26 20:39     ` Yazen Ghannam
2026-10-28  4:48       ` Veggalam, Rama Devi
2026-10-29 14:52         ` Michal Simek
2026-10-29 15:25           ` Borislav Petkov
2026-10-29 16:12             ` Michal Simek
2026-10-29 16:27               ` Borislav Petkov
2026-11-02 12:48                 ` Michal Simek
2026-11-02  7:05             ` Prasanna Kumar T S M [this message]
2026-10-21 12:57 ` [PATCH v4 2/3] firmware: xilinx: Add XilSEM firmware interface Rama devi Veggalam
2026-10-21 12:57 ` [PATCH v4 3/3] edac: xilinx: Add XilSEM CRAM/NPI error monitoring support Rama devi Veggalam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=133548dd-21de-4400-9acb-a424df75c90c@linux.microsoft.com \
    --to=ptsm@linux.microsoft.com \
    --cc=Yazen.Ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=james.morse@arm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=rama.devi.veggalam@amd.com \
    --cc=robh@kernel.org \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®