mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Herrmann <dh.herrmann@googlemail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH 3/7] rfkill: Do not change default values in EXPERT mode
Date: Sun, 13 May 2012 18:07:06 +0200	[thread overview]
Message-ID: <1336925230-2853-4-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1336925230-2853-1-git-send-email-dh.herrmann@googlemail.com>

Expert mode was designed to toggle visibility of options and not to
change their behavior. If a user wants to tweak a single value and
enables EXPERT mode to do this, he will have several unexpected
side effects when other subsystems toggle their default values based
on EXPERT mode. This makes EXPERT pretty useless.

Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 net/rfkill/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rfkill/Kconfig b/net/rfkill/Kconfig
index 78efe89..3d96f42 100644
--- a/net/rfkill/Kconfig
+++ b/net/rfkill/Kconfig
@@ -21,7 +21,7 @@ config RFKILL_INPUT
 	bool "RF switch input support" if EXPERT
 	depends on RFKILL
 	depends on INPUT = y || RFKILL = INPUT
-	default y if !EXPERT
+	default y
 
 config RFKILL_REGULATOR
 	tristate "Generic rfkill regulator driver"
-- 
1.7.10.2


  parent reply	other threads:[~2012-05-13 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 16:07 [PATCH 0/7] Remove side-effects of CONFIG_EXPERT David Herrmann
2012-05-13 16:07 ` [PATCH 1/7] HID: Do not switch default values in EXPERT mode David Herrmann
2012-05-14  8:23   ` Jiri Kosina
2012-05-13 16:07 ` [PATCH 2/7] Media: Do not change " David Herrmann
2012-05-13 16:07 ` David Herrmann [this message]
2012-05-13 16:07 ` [PATCH 4/7] Kconfig: Do not switch " David Herrmann
2012-05-13 16:07 ` [PATCH 5/7] usb: remove unneeded default value David Herrmann
2012-05-13 16:07 ` [PATCH 6/7] pcmcia: Do not change selected options in EXPERT mode David Herrmann
2012-05-13 16:07 ` [PATCH 7/7] drm: do not change selected options based on " David Herrmann
2012-05-13 16:18   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336925230-2853-4-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®