mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 4/7] Kconfig: Do not switch default values in EXPERT mode
Date: Sun, 13 May 2012 18:07:07 +0200	[thread overview]
Message-ID: <1336925230-2853-5-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1336925230-2853-1-git-send-email-dh.herrmann@googlemail.com>

We should avoid changing default values when EXPERT mode is enabled. Often
users enable EXPERT mode to change a single value. If other subsystems
change their defaults in EXPERT mode, the user might get a totally
different result as expected.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 init/Kconfig |    2 +-
 usr/Kconfig  |    8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index 6cfd71d..f16400d 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -801,7 +801,7 @@ config CHECKPOINT_RESTORE
 
 menuconfig NAMESPACES
 	bool "Namespaces support" if EXPERT
-	default !EXPERT
+	default y
 	help
 	  Provides the way to make tasks work with different objects using
 	  the same id. For example same IPC id may refer to different objects
diff --git a/usr/Kconfig b/usr/Kconfig
index 65b845b..065a0e3 100644
--- a/usr/Kconfig
+++ b/usr/Kconfig
@@ -56,7 +56,7 @@ config RD_GZIP
 
 config RD_BZIP2
 	bool "Support initial ramdisks compressed using bzip2" if EXPERT
-	default !EXPERT
+	default y
 	depends on BLK_DEV_INITRD
 	select DECOMPRESS_BZIP2
 	help
@@ -65,7 +65,7 @@ config RD_BZIP2
 
 config RD_LZMA
 	bool "Support initial ramdisks compressed using LZMA" if EXPERT
-	default !EXPERT
+	default y
 	depends on BLK_DEV_INITRD
 	select DECOMPRESS_LZMA
 	help
@@ -74,7 +74,7 @@ config RD_LZMA
 
 config RD_XZ
 	bool "Support initial ramdisks compressed using XZ" if EXPERT
-	default !EXPERT
+	default y
 	depends on BLK_DEV_INITRD
 	select DECOMPRESS_XZ
 	help
@@ -83,7 +83,7 @@ config RD_XZ
 
 config RD_LZO
 	bool "Support initial ramdisks compressed using LZO" if EXPERT
-	default !EXPERT
+	default y
 	depends on BLK_DEV_INITRD
 	select DECOMPRESS_LZO
 	help
-- 
1.7.10.2


  parent reply	other threads:[~2012-05-13 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 16:07 [PATCH 0/7] Remove side-effects of CONFIG_EXPERT David Herrmann
2012-05-13 16:07 ` [PATCH 1/7] HID: Do not switch default values in EXPERT mode David Herrmann
2012-05-14  8:23   ` Jiri Kosina
2012-05-13 16:07 ` [PATCH 2/7] Media: Do not change " David Herrmann
2012-05-13 16:07 ` [PATCH 3/7] rfkill: " David Herrmann
2012-05-13 16:07 ` David Herrmann [this message]
2012-05-13 16:07 ` [PATCH 5/7] usb: remove unneeded default value David Herrmann
2012-05-13 16:07 ` [PATCH 6/7] pcmcia: Do not change selected options in EXPERT mode David Herrmann
2012-05-13 16:07 ` [PATCH 7/7] drm: do not change selected options based on " David Herrmann
2012-05-13 16:18   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336925230-2853-5-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®