mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 6/7] pcmcia: Do not change selected options in EXPERT mode
Date: Sun, 13 May 2012 18:07:09 +0200	[thread overview]
Message-ID: <1336925230-2853-7-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1336925230-2853-1-git-send-email-dh.herrmann@googlemail.com>

EXPERT mode is supposed to toggle the visibility of config options, it
should never modify them, though. If users enable EXPERT mode to change a
single value, they might get unwanted side-effects with our current
behavior.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/pcmcia/Kconfig |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
index bba3ab2..ef0dbf9 100644
--- a/drivers/pcmcia/Kconfig
+++ b/drivers/pcmcia/Kconfig
@@ -69,7 +69,6 @@ comment "PC-card bridges"
 config YENTA
 	tristate "CardBus yenta-compatible bridge support"
 	depends on PCI
-	select CARDBUS if !EXPERT
 	select PCCARD_NONSTATIC if PCMCIA != n
 	---help---
 	  This option enables support for CardBus host bridges.  Virtually
-- 
1.7.10.2


  parent reply	other threads:[~2012-05-13 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 16:07 [PATCH 0/7] Remove side-effects of CONFIG_EXPERT David Herrmann
2012-05-13 16:07 ` [PATCH 1/7] HID: Do not switch default values in EXPERT mode David Herrmann
2012-05-14  8:23   ` Jiri Kosina
2012-05-13 16:07 ` [PATCH 2/7] Media: Do not change " David Herrmann
2012-05-13 16:07 ` [PATCH 3/7] rfkill: " David Herrmann
2012-05-13 16:07 ` [PATCH 4/7] Kconfig: Do not switch " David Herrmann
2012-05-13 16:07 ` [PATCH 5/7] usb: remove unneeded default value David Herrmann
2012-05-13 16:07 ` David Herrmann [this message]
2012-05-13 16:07 ` [PATCH 7/7] drm: do not change selected options based on EXPERT mode David Herrmann
2012-05-13 16:18   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336925230-2853-7-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®