mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: <rtc-linux@googlegroups.com>
Cc: <linux-kernel@vger.kernel.org>, <julia.lawall@lip6.fr>,
	Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: [PATCH 2/7] rtc: Convert struct i2c_msg initialization to C99 format
Date: Mon, 17 Sep 2012 19:28:09 +0530	[thread overview]
Message-ID: <1347890294-28467-3-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com>

    Convert the struct i2c_msg initialization to C99 format. This makes
    maintaining and editing the code simpler. Also helps once other fields
    like transferred are added in future.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/rtc/rtc-em3027.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-em3027.c b/drivers/rtc/rtc-em3027.c
index 0104ea7..373f7e5 100644
--- a/drivers/rtc/rtc-em3027.c
+++ b/drivers/rtc/rtc-em3027.c
@@ -49,8 +49,8 @@ static int em3027_get_time(struct device *dev, struct rtc_time *tm)
 	unsigned char buf[7];
 
 	struct i2c_msg msgs[] = {
-		{client->addr, 0, 1, &addr},		/* setup read addr */
-		{client->addr, I2C_M_RD, 7, buf},	/* read time/date */
+		{.addr = client->addr, .flags = 0, .len = 1, .buf = &addr},		/* setup read addr */
+		{.addr = client->addr, .flags = I2C_M_RD, .len = 7, .buf = buf},	/* read time/date */
 	};
 
 	/* read time/date registers */
@@ -76,7 +76,7 @@ static int em3027_set_time(struct device *dev, struct rtc_time *tm)
 	unsigned char buf[8];
 
 	struct i2c_msg msg = {
-		client->addr, 0, 8, buf,	/* write time/date */
+		.addr = client->addr, .flags = 0, .len = 8, .buf = buf,	/* write time/date */
 	};
 
 	buf[0] = EM3027_REG_WATCH_SEC;
-- 
1.7.5.4


  parent reply	other threads:[~2012-09-17 13:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17 13:58 [PATCH 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format Shubhrajyoti D
2012-09-18  1:44   ` Ryan Mallon
2012-09-18  6:05     ` Shubhrajyoti
2012-09-18  6:10       ` Ryan Mallon
2012-09-17 13:58 ` Shubhrajyoti D [this message]
2012-09-17 13:58 ` [PATCH 3/7] " Shubhrajyoti D
2012-09-18  1:45   ` Ryan Mallon
2012-09-18  5:38     ` Shubhrajyoti
2012-09-18  1:51   ` Ryan Mallon
2012-09-18  5:40     ` Shubhrajyoti
2012-09-18  5:47       ` Ryan Mallon
2012-09-18  5:53         ` Julia Lawall
2012-09-17 13:58 ` [PATCH 4/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 5/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 6/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 7/7] " Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347890294-28467-3-git-send-email-shubhrajyoti@ti.com \
    --to=shubhrajyoti@ti.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®